-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggleable password input #1159
Merged
julianpoy
merged 2 commits into
julianpoy:master
from
jonathanmsnow:toggleable-password-input
Dec 11, 2023
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
packages/frontend/src/app/directives/toggleable-password.directive.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
import { Directive, ElementRef, Renderer2 } from "@angular/core"; | ||
|
||
@Directive({ | ||
selector: "[appToggleablePassword]", | ||
}) | ||
export class ToggleablePasswordDirective { | ||
private showPassword = false; | ||
private eyeIcon!: HTMLElement; | ||
|
||
constructor( | ||
private el: ElementRef, | ||
private renderer: Renderer2, | ||
) { | ||
this.setup(); | ||
} | ||
|
||
setup() { | ||
// Create the eye icon for showing/hiding password | ||
this.eyeIcon = this.renderer.createElement("ion-icon"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I noticed while testing that this needs cursor: pointer. For accessibility, it'd also be nice for this to be a button (which would solve the problem anyway). You could use the icon-only button here |
||
this.renderer.addClass(this.eyeIcon, "medium-icon"); | ||
this.renderer.addClass(this.eyeIcon, "eye-icon"); | ||
this.renderer.setAttribute(this.eyeIcon, "name", "eye-off-outline"); | ||
this.renderer.listen(this.eyeIcon, "click", () => this.toggleShow()); | ||
|
||
// Append the eye icon next to the input field | ||
this.renderer.appendChild(this.el.nativeElement.parentNode, this.eyeIcon); | ||
} | ||
|
||
toggleShow() { | ||
this.showPassword = !this.showPassword; | ||
const passwordInput = this.el.nativeElement; | ||
passwordInput.type = this.showPassword ? "text" : "password"; | ||
|
||
const iconName = this.showPassword ? "eye-outline" : "eye-off-outline"; | ||
this.renderer.setAttribute(this.eyeIcon, "name", iconName); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[non-blocking] Would be nice for these styles not to sit in the global app.scss, but it looks like directives can't apply stylesheets directly. I do see some mention of directives supporting a
host
property here, though https://stackoverflow.com/a/35915497/21691840