Toggleable password input #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RecipeSage into toggleable-password-input
julianpoy
reviewed
Dec 10, 2023
Comment on lines
+33
to
+40
| .medium-icon { | ||
| font-size: 2em; | ||
| } | ||
|
|
||
| .eye-icon { | ||
| vertical-align: middle; | ||
| } | ||
|
|
There was a problem hiding this comment.
[non-blocking] Would be nice for these styles not to sit in the global app.scss, but it looks like directives can't apply stylesheets directly. I do see some mention of directives supporting a host property here, though https://stackoverflow.com/a/35915497/21691840
julianpoy
reviewed
Dec 10, 2023
|
|
||
| setup() { | ||
| // Create the eye icon for showing/hiding password | ||
| this.eyeIcon = this.renderer.createElement("ion-icon"); |
There was a problem hiding this comment.
I noticed while testing that this needs cursor: pointer. For accessibility, it'd also be nice for this to be a button (which would solve the problem anyway). You could use the icon-only button here
|
Will add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a hide/show ability through a directive that can be applied to inputs which resolves issue #462