-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggleable password input #1159
Toggleable password input #1159
Conversation
…RecipeSage into toggleable-password-input
.medium-icon { | ||
font-size: 2em; | ||
} | ||
|
||
.eye-icon { | ||
vertical-align: middle; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[non-blocking] Would be nice for these styles not to sit in the global app.scss, but it looks like directives can't apply stylesheets directly. I do see some mention of directives supporting a host
property here, though https://stackoverflow.com/a/35915497/21691840
|
||
setup() { | ||
// Create the eye icon for showing/hiding password | ||
this.eyeIcon = this.renderer.createElement("ion-icon"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed while testing that this needs cursor: pointer. For accessibility, it'd also be nice for this to be a button (which would solve the problem anyway). You could use the icon-only button here
Will add the |
Adds a hide/show ability through a directive that can be applied to inputs which resolves issue #462