Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sophisticated "maintenance" demo #27

Merged
merged 3 commits into from
Dec 18, 2020

Conversation

timholy
Copy link
Member

@timholy timholy commented Dec 15, 2020

I'm not sure what folks think about having something this "sophisticated" (aka, likely to go stale...), but at a time when many people need to be transitioning from travis to GitHub actions, this script can take most of the manual work away.

It relies on JuliaWeb/GitHub.jl#179, so we shouldn't merge this until its fate is decided.

@codecov-io
Copy link

codecov-io commented Dec 15, 2020

Codecov Report

Merging #27 (6adbbe9) into master (0464261) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   13.33%   13.33%           
=======================================
  Files           6        6           
  Lines         105      105           
=======================================
  Hits           14       14           
  Misses         91       91           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0464261...6adbbe9. Read the comment docs.

@timholy timholy force-pushed the teh/maintenance_demo branch 2 times, most recently from f77351c to f0b64f4 Compare December 15, 2020 12:07
demos/maintenance.jl Outdated Show resolved Hide resolved
Copy link
Contributor

@mschauer mschauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I get all of them?

demos/maintenance.jl Outdated Show resolved Hide resolved
demos/maintenance.jl Outdated Show resolved Hide resolved
demos/maintenance.jl Outdated Show resolved Hide resolved
demos/maintenance.jl Outdated Show resolved Hide resolved
demos/maintenance.jl Outdated Show resolved Hide resolved
demos/maintenance.jl Outdated Show resolved Hide resolved
demos/maintenance.jl Outdated Show resolved Hide resolved
demos/maintenance.jl Outdated Show resolved Hide resolved
demos/maintenance.jl Outdated Show resolved Hide resolved
timholy added a commit that referenced this pull request Dec 17, 2020
Before merging #27 I think (since it won't be tested) that we should give it a Project.toml and commit a Manifest that locks in working versions. I want to make sure #29 is part of MassInstallAction, so we need a new registered version.
@timholy timholy mentioned this pull request Dec 17, 2020
timholy added a commit that referenced this pull request Dec 17, 2020
Before merging #27 I think that we should give it a Project.toml and commit a Manifest that locks in working versions. I want to make sure #29 is included, so we need a new registered version.
timholy and others added 3 commits December 17, 2020 04:59
This should ensure it stays working despite
not being tested (for obvious reasons).
@timholy
Copy link
Member Author

timholy commented Dec 17, 2020

OK, I think this is now ready to go. I turned it into a project, but in the end I opted for [compat] bounds rather than checking in the Manifest. Happy to change this if others disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants