-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from Travis CI to GitHub Actions #37
Conversation
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
+ Coverage 74.44% 82.78% +8.34%
==========================================
Files 1 1
Lines 90 122 +32
==========================================
+ Hits 67 101 +34
+ Misses 23 21 -2
Continue to review full report at Codecov.
|
.github/workflows/CI.yml
Outdated
on: | ||
- push | ||
- pull_request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to avoid duplicated CI running when the PR is from the repo, so here limit push
to master
branch only.
on: | |
- push | |
- pull_request | |
on: | |
create: | |
tags: | |
push: | |
branches: | |
- master | |
pull_request: | |
schedule: | |
- cron: '20 00 1 * *' |
Also, CI on tags and cron jobs sound worth to have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think on: create
is a thing. I'll update the settings appropriately though
Thanks, @omus! FYI if you have many workflow updates, julia-actions/MassInstallAction.jl#27 may be handy (does key & secret updates and updates for TagBot, Documenter, and CI). Handling the badge was a nice touch I hadn't yet considered. |
No description provided.