Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Travis CI to GitHub Actions #37

Merged
merged 2 commits into from
Dec 18, 2020

Conversation

omus
Copy link
Contributor

@omus omus commented Dec 17, 2020

No description provided.

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #37 (78c800e) into master (0795578) will increase coverage by 8.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   74.44%   82.78%   +8.34%     
==========================================
  Files           1        1              
  Lines          90      122      +32     
==========================================
+ Hits           67      101      +34     
+ Misses         23       21       -2     
Impacted Files Coverage Δ
src/MappedArrays.jl 82.78% <100.00%> (+8.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90c6fce...78c800e. Read the comment docs.

Comment on lines 2 to 4
on:
- push
- pull_request
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to avoid duplicated CI running when the PR is from the repo, so here limit push to master branch only.

Suggested change
on:
- push
- pull_request
on:
create:
tags:
push:
branches:
- master
pull_request:
schedule:
- cron: '20 00 1 * *'

Also, CI on tags and cron jobs sound worth to have.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think on: create is a thing. I'll update the settings appropriately though

@timholy timholy merged commit 9ab9efe into JuliaArrays:master Dec 18, 2020
@timholy
Copy link
Member

timholy commented Dec 18, 2020

Thanks, @omus!

FYI if you have many workflow updates, julia-actions/MassInstallAction.jl#27 may be handy (does key & secret updates and updates for TagBot, Documenter, and CI). Handling the badge was a nice touch I hadn't yet considered.

@omus omus deleted the cv/switch-gha branch December 21, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants