Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JUJU-1577] Replace k8s bundles with machine bundles for tests #703

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

cderici
Copy link
Contributor

@cderici cderici commented Aug 8, 2022

Description

Some of the tests in the CI are failing because we’re using k8s bundles while running the tests on lxd (don’t ask why they were passing before). This change replaces them with a machine bundle.

QA Steps

tox -e integration -- tests/integration/test_model.py::test_deploy_trusted_bundle
tox -e integration -- tests/integration/test_model.py::test_deploy_bundle

Notes & Discussion

We're running the integration tests on LXD
Copy link
Contributor

@juanmanuel-tirado juanmanuel-tirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

@cderici
Copy link
Contributor Author

cderici commented Aug 8, 2022

/merge

@jujubot jujubot merged commit 871c10c into juju:master Aug 8, 2022
jujubot added a commit that referenced this pull request Aug 9, 2022
#704

Tuesday August 9 2022

## What's Changed

Switching to semantic versioning. From this release on, at least the major release number matches
the most recent Juju supported. Hence the jump to `3.0.0` since this release supports `Juju 3.0`.
(This also means that `python-libjuju <= 2.9.11` only support up to `Juju 2.x`)

* [JUJU-1439] Initial fixes for `test_model` to pass with juju 3.0 by @cderici in #689
* [JUJU-1464] More fixes for 3.0 compatibility by @cderici in #691
* [JUJU-1457] Merge 3.0 compatibility branch onto master by @cderici in #692
* Fix conditional by @sed-i in #696
* [JUJU-1534] Fix `model.connect_current()` by @cderici in #697
* [JUJU-1542] Fix run actions on units by @cderici in #698
* [JUJU-1577] Replace k8s bundles with machine bundles for tests by @cderici in #703
* [JUJU-1528] Add storage implementation by @cderici in #701

[JUJU-1439]: https://warthogs.atlassian.net/browse/JUJU-1439?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[JUJU-1464]: https://warthogs.atlassian.net/browse/JUJU-1464?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[JUJU-1457]: https://warthogs.atlassian.net/browse/JUJU-1457?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[JUJU-1534]: https://warthogs.atlassian.net/browse/JUJU-1534?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[JUJU-1542]: https://warthogs.atlassian.net/browse/JUJU-1542?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[JUJU-1577]: https://warthogs.atlassian.net/browse/JUJU-1577?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[JUJU-1528]: https://warthogs.atlassian.net/browse/JUJU-1528?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
@cderici cderici deleted the machine-bundles-for-tests branch August 9, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants