[JUJU-1439] Initial fixes for test_model to pass with juju 3.0
#689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to use the ModelInfo from the ModelManagerFacade
previously it was ClientFacade.GetModelConstraints
ClientFacade.DestroyMachines -> MachineManager.DestroyMachineWithParams
- fix bundle actions to use updated facades - update the bundle being used to use charmhub - replace charmhub.info with a manual api call to get charm id - minor fixes for linter etc
|
/merge |
jujubot
added a commit
that referenced
this pull request
Aug 9, 2022
#704 Tuesday August 9 2022 ## What's Changed Switching to semantic versioning. From this release on, at least the major release number matches the most recent Juju supported. Hence the jump to `3.0.0` since this release supports `Juju 3.0`. (This also means that `python-libjuju <= 2.9.11` only support up to `Juju 2.x`) * [JUJU-1439] Initial fixes for `test_model` to pass with juju 3.0 by @cderici in #689 * [JUJU-1464] More fixes for 3.0 compatibility by @cderici in #691 * [JUJU-1457] Merge 3.0 compatibility branch onto master by @cderici in #692 * Fix conditional by @sed-i in #696 * [JUJU-1534] Fix `model.connect_current()` by @cderici in #697 * [JUJU-1542] Fix run actions on units by @cderici in #698 * [JUJU-1577] Replace k8s bundles with machine bundles for tests by @cderici in #703 * [JUJU-1528] Add storage implementation by @cderici in #701 [JUJU-1439]: https://warthogs.atlassian.net/browse/JUJU-1439?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-1464]: https://warthogs.atlassian.net/browse/JUJU-1464?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-1457]: https://warthogs.atlassian.net/browse/JUJU-1457?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-1534]: https://warthogs.atlassian.net/browse/JUJU-1534?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-1542]: https://warthogs.atlassian.net/browse/JUJU-1542?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-1577]: https://warthogs.atlassian.net/browse/JUJU-1577?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-1528]: https://warthogs.atlassian.net/browse/JUJU-1528?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the first of a bunch of PRs to enable pylibjuju to support Juju 3.0.
In particular, the aim of this PR is to have all the tests in the
test_model.pyto pass, which constitutes a significant portion of libjuju's operational logic.Includes 12 commits. The summary of the changes is:
ClientFacadefor a bunch of functions to use their respective correct Facades.CharmHub.Info()to get some basic charm info to deploy stuff, however, since CharmHub facade doesn't exist anymore in juju 3.0, I replaced it with a simple api call to the charmhub itself to get the necessary info.QA Steps
All the tests in
test_model.pyshould pass on ajuju 3.0controller.So bootstrap from juju's
developbranch (orsnap install juju --channel=latest/beta) and run the following in libjuju:tox -e integration -- tests/integration/test_model.pyNotes & Discussion
juju-3.0-compatibilitybranch, not the main branch.