Charmstore compatability of deploying bundles #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
7 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
addyess
force-pushed
the
charmhub-compatability
branch
from
ed954fa to
0244669
Compare
SimonRichardson
approved these changes
Mar 10, 2022
|
!!build!! |
|
I see failures, but i can't tell if they're failures i've caused. |
|
!!build!! |
|
@addyess The test failures are not about your work, this PR can be merged. I see the failing test, namely |
|
Thanks @cderici and @SimonRichardson. I don't have merge privs on this repo. Would either of you mind merge + releasing. Thanks so much |
jujubot
added a commit
that referenced
this pull request
Mar 21, 2022
#655 ## What's Changed * [JUJU-567] Use ModelManager instead of ControllerFacade to list available models by @cderici in #632 * [JUJU-573] Fix charm resolution for Juju 2.8.11 by @cderici in #633 * [JUJU-704] Remove non-implemented (stuıb) functions by @cderici in #646 * [JUJU-676] Avoid defaulting to empty string for charm origin by @cderici in #647 * Charmstore compatability of deploying bundles by @addyess in #650 * [JUJU-731] Subordinate charm num unit by @cderici in #648 * [JUJU-769] Facade schemas for 2.9.27 by @cderici in #652 * [JUJU-771] Auto switch to scale from add_unit on container based models by @cderici in #653 [JUJU-567]: https://warthogs.atlassian.net/browse/JUJU-567?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-573]: https://warthogs.atlassian.net/browse/JUJU-573?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-704]: https://warthogs.atlassian.net/browse/JUJU-704?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-676]: https://warthogs.atlassian.net/browse/JUJU-676?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-731]: https://warthogs.atlassian.net/browse/JUJU-731?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-769]: https://warthogs.atlassian.net/browse/JUJU-769?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-771]: https://warthogs.atlassian.net/browse/JUJU-771?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #649