[JUJU-704] Remove non-implemented (stuıb) functions #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... instead of raising NotImplementedError. Note that we still use the NotImplementedError for vaious sub-functionalities or corner cases that are yet to be implementeed. This only removes the functions that stays in the code as stubs.
SimonRichardson
approved these changes
Mar 3, 2022
|
!!build!! |
|
|
jujubot
added a commit
that referenced
this pull request
Mar 21, 2022
#655 ## What's Changed * [JUJU-567] Use ModelManager instead of ControllerFacade to list available models by @cderici in #632 * [JUJU-573] Fix charm resolution for Juju 2.8.11 by @cderici in #633 * [JUJU-704] Remove non-implemented (stuıb) functions by @cderici in #646 * [JUJU-676] Avoid defaulting to empty string for charm origin by @cderici in #647 * Charmstore compatability of deploying bundles by @addyess in #650 * [JUJU-731] Subordinate charm num unit by @cderici in #648 * [JUJU-769] Facade schemas for 2.9.27 by @cderici in #652 * [JUJU-771] Auto switch to scale from add_unit on container based models by @cderici in #653 [JUJU-567]: https://warthogs.atlassian.net/browse/JUJU-567?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-573]: https://warthogs.atlassian.net/browse/JUJU-573?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-704]: https://warthogs.atlassian.net/browse/JUJU-704?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-676]: https://warthogs.atlassian.net/browse/JUJU-676?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-731]: https://warthogs.atlassian.net/browse/JUJU-731?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-769]: https://warthogs.atlassian.net/browse/JUJU-769?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-771]: https://warthogs.atlassian.net/browse/JUJU-771?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the stub functions that just raise
NotImplementedError. Note that we still use that error for vaious sub-functionalities or corner cases that are yet to be implemented. This only removes the functions that stays in the code as stubs.QA Steps
Notes & Discussion
This also introduces
AbstractMethodErrorfor@abstractmethodfunctions to raise instead of raising theNotImplementedError.