Fix integration tests #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to handle the values of type other than dict
|
We got two cases that are failing regardless of the Python version, and they are already reported in #535. tests/integration/test_model.py::test_local_oci_image_resource_charm seems to be failing for all Python versions (except for 3.8) Other than those cases, we have a bunch that are failing in different versions, here's what seems to be going on: 3.93.83.73.63.5 |
juanmanuel-tirado
approved these changes
Sep 17, 2021
jujubot
added a commit
that referenced
this pull request
Oct 12, 2021
#547 ### Description This is a continuation of #544. There are still some integration tests failing on `pylibjuju`'s side, so this PR attempts to fix all of them. Hopefully at the end of this we'll merge with a green ticks across the board. This PR currently has 4 commits that: - adjusts a timeout for a unit's workload_status to be updated - use a wrapper `block_until` method that takes also the disconnections into account when blocking - small lint fix - patches a test that actually needs to use the default `block_until` ### QA steps ``` make test ``` ### Notes & Discussion There might still be some cases that fail on the CI, we'll fix them here and hopefully eventually merge with flying colors. Please **don't merge** until all the tests are passing.
SimonRichardson
added a commit
to SimonRichardson/python-libjuju
that referenced
this pull request
Oct 12, 2021
2.9.4 ^^^^^ Tuesday October 12 2021 * Charmhub deploy charm by @SimonRichardson in juju#483 * add wait_for_status instead of wait_for_active by @sed-i in juju#517 * Adds resource support for charmhub deployments by @tlm in juju#516 * Fix bug juju#519 and juju#522: Add local resources for bundles by @davigar15 in juju#520 * Patching some missing kwargs by @cderici in juju#527 * Implementing `backup` functionality by @cderici in juju#536 * Fix issue 532: Set the default_series properly by @davigar15 in juju#533 * A random small bug fix by @cderici in juju#541 * Allow ApplicationFacade set_config with non-string values by @cderici in juju#540 * Skip macaroon tests issue 534 by @cderici in juju#542 * Fix issue 530: Check the controller for unsynched models by @cderici in juju#539 * Upgrade setup-python action. by @juanmanuel-tirado in juju#543 * Fix integration tests by @cderici in juju#544 * Bring juju/juju.py into life by @cderici in juju#546 * Extract resources info from apps in locally deployed bundle by cderici in juju#552 * Fix for simple bug in bundle deployment code self.charm -> self['charm'] by @jnsgruk in ttps://github.com/juju/pull/558 * Fix integration tests continued by @cderici in ttps://github.com/juju/pull/547 * Get the config dir resolve logic into one place by @cderici in ttps://github.com/juju/pull/555 * Complete the backups functionality by @cderici in ttps://github.com/juju/pull/556
Merged
jujubot
added a commit
that referenced
this pull request
Oct 12, 2021
#561 2.9.4 ^^^^^ Tuesday October 12 2021 * Charmhub deploy charm by @SimonRichardson in #483 * add wait_for_status instead of wait_for_active by @sed-i in #517 * Adds resource support for charmhub deployments by @tlm in #516 * Fix bug #519 and #522: Add local resources for bundles by @davigar15 in #520 * Patching some missing kwargs by @cderici in #527 * Implementing `backup` functionality by @cderici in #536 * Fix issue 532: Set the default_series properly by @davigar15 in #533 * A random small bug fix by @cderici in #541 * Allow ApplicationFacade set_config with non-string values by @cderici in #540 * Skip macaroon tests issue 534 by @cderici in #542 * Fix issue 530: Check the controller for unsynched models by @cderici in #539 * Upgrade setup-python action. by @juanmanuel-tirado in #543 * Fix integration tests by @cderici in #544 * Bring juju/juju.py into life by @cderici in #546 * Extract resources info from apps in locally deployed bundle by cderici in #552 * Fix for simple bug in bundle deployment code self.charm -> self['charm'] by @jnsgruk in ttps://github.com//pull/558 * Fix integration tests continued by @cderici in ttps://github.com//pull/547 * Get the config dir resolve logic into one place by @cderici in ttps://github.com//pull/555 * Complete the backups functionality by @cderici in ttps://github.com//pull/556
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apparently there are still some integration tests failing on
pylibjuju's side, so this PR attempts to fix all of them. Hopefully at the end of this we'll merge with a green ticks across the board.This PR currently has 3 commits that:
QA steps
Notes & Discussion
There might still be some cases that fail on the CI, we'll fix them here and hopefully eventually merge with flying colors.