Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add wait_for_status instead of wait_for_active #517

Merged
merged 6 commits into from
Aug 17, 2021
Merged

add wait_for_status instead of wait_for_active #517

merged 6 commits into from
Aug 17, 2021

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Aug 6, 2021

No description provided.

@jujubot
Copy link
Contributor

jujubot commented Aug 6, 2021

Can one of the admins verify this patch?

6 similar comments
@jujubot
Copy link
Contributor

jujubot commented Aug 6, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Contributor

jujubot commented Aug 6, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Contributor

jujubot commented Aug 6, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Contributor

jujubot commented Aug 6, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Contributor

jujubot commented Aug 6, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Contributor

jujubot commented Aug 6, 2021

Can one of the admins verify this patch?

johnsca
johnsca reviewed Aug 6, 2021
View reviewed changes
Copy link
Contributor

@johnsca johnsca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. However, there are some integration tests which use wait_for_idle(wait_for_active=True) and if that is going to be deprecated, those should be updated (and maybe a regression test included).

@sed-i
Copy link
Contributor Author

sed-i commented Aug 9, 2021 •
edited
Loading

Added unit tests.

@sed-i
Copy link
Contributor Author

sed-i commented Aug 9, 2021

@johnsca how about renaming wait_for_status to simply status, such that await ops_test.model.wait_for_idle(status="active")

@johnsca
Copy link
Contributor

johnsca commented Aug 10, 2021

+1 to status. That seems plenty clear and much less typing.

@sed-i
Copy link
Contributor Author

sed-i commented Aug 11, 2021

@johnsca: renamed to status and patched timedelta

@sed-i sed-i marked this pull request as ready for review August 11, 2021 21:10
SimonRichardson
SimonRichardson reviewed Aug 16, 2021
View reviewed changes
tox.ini
@@ -10,6 +10,9 @@ skipsdist=True
[pytest]
markers =
serial: mark a test that must run by itself
filterwarnings =
ignore::DeprecationWarning:asynctest
ignore::DeprecationWarning:websockets
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@SimonRichardson
Copy link
Member

!!build!!

@SimonRichardson
Copy link
Member

$$merge$$

1 similar comment
@SimonRichardson
Copy link
Member

$$merge$$

@jujubot jujubot merged commit 7a853c0 into juju:master Aug 17, 2021
@sed-i sed-i deleted the feature/wait_for_status branch August 17, 2021 13:28
@sed-i sed-i mentioned this pull request Aug 20, 2021
Merged
SimonRichardson added a commit to SimonRichardson/python-libjuju that referenced this pull request Oct 12, 2021
@SimonRichardson
Release 2.9.4 notes
957101e 
2.9.4
^^^^^

Tuesday October 12 2021

* Charmhub deploy charm by @SimonRichardson in juju#483
* add wait_for_status instead of wait_for_active by @sed-i in juju#517
* Adds resource support for charmhub deployments by @tlm in juju#516
* Fix bug juju#519 and juju#522: Add local resources for bundles by @davigar15 in juju#520
* Patching some missing kwargs by @cderici in juju#527
* Implementing `backup` functionality by @cderici in juju#536
* Fix issue 532: Set the default_series properly by @davigar15 in juju#533
* A random small bug fix by @cderici in juju#541
* Allow ApplicationFacade set_config with non-string values by @cderici in juju#540
* Skip macaroon tests issue 534 by @cderici in juju#542
* Fix issue 530: Check the controller for unsynched models by @cderici in juju#539
* Upgrade setup-python action. by @juanmanuel-tirado in juju#543
* Fix integration tests by @cderici in juju#544
* Bring juju/juju.py into life by @cderici in juju#546
* Extract resources info from apps in locally deployed bundle by cderici in juju#552
* Fix for simple bug in bundle deployment code self.charm -> self['charm'] by @jnsgruk in ttps://github.com/juju/pull/558
* Fix integration tests continued by @cderici in ttps://github.com/juju/pull/547
* Get the config dir resolve logic into one place by @cderici in ttps://github.com/juju/pull/555
* Complete the backups functionality by @cderici in ttps://github.com/juju/pull/556
@SimonRichardson SimonRichardson mentioned this pull request Oct 12, 2021
Merged
jujubot added a commit that referenced this pull request Oct 12, 2021
@jujubot
Merge pull request #561 from SimonRichardson/release-2.9.4
c1a593c 
#561

2.9.4
^^^^^

Tuesday October 12 2021

* Charmhub deploy charm by @SimonRichardson in #483
* add wait_for_status instead of wait_for_active by @sed-i in #517
* Adds resource support for charmhub deployments by @tlm in #516
* Fix bug #519 and #522: Add local resources for bundles by @davigar15 in #520
* Patching some missing kwargs by @cderici in #527
* Implementing `backup` functionality by @cderici in #536
* Fix issue 532: Set the default_series properly by @davigar15 in #533
* A random small bug fix by @cderici in #541
* Allow ApplicationFacade set_config with non-string values by @cderici in #540
* Skip macaroon tests issue 534 by @cderici in #542
* Fix issue 530: Check the controller for unsynched models by @cderici in #539
* Upgrade setup-python action. by @juanmanuel-tirado in #543
* Fix integration tests by @cderici in #544
* Bring juju/juju.py into life by @cderici in #546
* Extract resources info from apps in locally deployed bundle by cderici in #552
* Fix for simple bug in bundle deployment code self.charm -> self['charm'] by @jnsgruk in ttps://github.com//pull/558
* Fix integration tests continued by @cderici in ttps://github.com//pull/547
* Get the config dir resolve logic into one place by @cderici in ttps://github.com//pull/555
* Complete the backups functionality by @cderici in ttps://github.com//pull/556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonRichardson SimonRichardson SimonRichardson approved these changes

@johnsca johnsca johnsca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sed-i @jujubot @johnsca @SimonRichardson