Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: integration tests against multiple juju versions #1163

Merged
merged 7 commits into from
Oct 17, 2024
Merged

ci: integration tests against multiple juju versions #1163

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cb1cf5b
ci: integration tests against multiple juju versions
dimaqq Oct 16, 2024
e05e60e
ci: cancel in progress
dimaqq Oct 16, 2024
0a30112
ci: don't test against juju 3.6 yet
dimaqq Oct 16, 2024
966c555
ci: control progress on error
dimaqq Oct 16, 2024
9c21a9a
ci: run unit tests on wider variety of Pythons
dimaqq Oct 16, 2024
bed9eae
ci: don't block quanrantined tests
dimaqq Oct 17, 2024
c7abedc
ci: udpate continue markers and explain why
dimaqq Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ name: Testing

on: [push, pull_request, workflow_dispatch]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
dimaqq marked this conversation as resolved.
Show resolved Hide resolved

jobs:
lint:
name: Linter
Expand Down Expand Up @@ -69,8 +73,12 @@ jobs:
strategy:
matrix:
python:
- "3.8"
- "3.9"
- "3.10"
- "3.11"
- "3.12"
- "3.13"
steps:
- name: Check out code
uses: actions/checkout@v4
Expand All @@ -95,6 +103,18 @@ jobs:
# save some resources for now.
# - "3.9"
- "3.10"
juju:
- "3.1/stable"
- "3.3/stable"
- "3.4/stable"
- "3.5/stable"
# A bunch of tests fail with juju.errors.JujuError: base: [email protected]/stable
# * test_subordinate_units
# * test_destroy_unit
# * test_ssh
# * ...
# - "3.6/beta"
continue-on-error: false # don't ignore if tests against some juju version fail
steps:
- name: Check out code
uses: actions/checkout@v4
Expand All @@ -106,7 +126,7 @@ jobs:
uses: charmed-kubernetes/actions-operator@main
with:
provider: lxd
juju-channel: 3.4/stable
juju-channel: ${{ matrix.juju }}
# 2023-01-11 Commented until we discover a
# clear approach for this.
# - name: Set proxy in controller
Expand Down Expand Up @@ -138,6 +158,7 @@ jobs:
- name: Run integration
# Force one single concurrent test
run: tox -e integration
continue-on-error: true # so that other juju versions are tested
james-garner-canonical marked this conversation as resolved.
Show resolved Hide resolved

integration-quarantine:
dimaqq marked this conversation as resolved.
Show resolved Hide resolved
name: Quarantined Integration Tests
Expand All @@ -148,6 +169,11 @@ jobs:
matrix:
python:
- "3.10"
juju:
- "3.1/stable"
- "3.3/stable"
- "3.4/stable"
- "3.5/stable"
steps:
- name: Check out code
uses: actions/checkout@v3
Expand All @@ -159,6 +185,7 @@ jobs:
uses: charmed-kubernetes/actions-operator@main
with:
provider: lxd
juju-channel: 3.4/stable
juju-channel: ${{ matrix.juju }}
- name: Run integration
run: tox -e integration-quarantine
dimaqq marked this conversation as resolved.
Show resolved Hide resolved
continue-on-error: true # so that other juju versions are tested
Loading