Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: integration tests against multiple juju versions #1163

Merged
merged 7 commits into from
Oct 17, 2024

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Oct 16, 2024

Integration tests against Juju 3.1, 3.3, 3.4, 3.5 (was: 3.4)
Unit tests against Python 3.83.13 (was: 3.93.10)

Notes: Juju 3.6 deprecated some bases (?) and many integration tests fail. Given that it's in beta, deferring that to a separate PR.

@dimaqq dimaqq force-pushed the multiple-juju-versions branch from 46328bf to 3018335 Compare October 16, 2024 08:14
@dimaqq dimaqq marked this pull request as ready for review October 16, 2024 08:15
Copy link
Contributor

@james-garner-canonical james-garner-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of learning questions from me, and one that might require action -- should integration-quarantine have the same setup with continue-on-error as integration does?

.github/workflows/test.yaml Outdated Show resolved Hide resolved
.github/workflows/test.yaml Show resolved Hide resolved
.github/workflows/test.yaml Show resolved Hide resolved
@dimaqq dimaqq force-pushed the multiple-juju-versions branch from 4046e33 to bed9eae Compare October 17, 2024 01:49
@dimaqq
Copy link
Contributor Author

dimaqq commented Oct 17, 2024

/merge

@jujubot jujubot merged commit 35ee88e into juju:main Oct 17, 2024
22 of 23 checks passed
@dimaqq dimaqq deleted the multiple-juju-versions branch October 17, 2024 05:40
jujubot added a commit that referenced this pull request Oct 30, 2024
#1167

Looks like I was wrong in #1163 
Using https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast instead.
Skip tests that are guaranteed to fail against older Juju controllers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants