to fix the format option issue #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @showjason , please fix the unit test. thx! |
Ah...sorry, I missed some particular cases, let me fix. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #786 +/- ##
==========================================
+ Coverage 36.72% 36.75% +0.02%
==========================================
Files 36 36
Lines 4351 4353 +2
==========================================
+ Hits 1598 1600 +2
Misses 2605 2605
Partials 148 148
☔ View full report in Codecov by Sentry. |
|
/lgtm |
|
@Hexilee PTAL |
Hexilee
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#773
I see the subcommand
formatsupports multiple secret key-like options whose value will contain=most likely, therefore I try to useSplitNto split the options to fixed length 2, so that the=in the value can be ignored. If it's not reasonable, please let me know