[BUG] invalid format options

[jianghushinian]

What happened:

When I use temporary access credentials for Huawei obs, I get the following error:

invalid format options: xxx

What you expected to happen:

no errors.

How to reproduce it (as minimally and precisely as possible):

Secret YAML example:

apiVersion: v1
kind: Secret
metadata:
  name: juicefs-secret
  namespace: kube-system
type: Opaque
stringData:
  name: juicefs-test
  metaurl: redisurl
  storage: obs
  bucket: obs-bucket
  access-key: ak
  secret-key: sk
  format-options: session-token=xxxxxxx=

Because the session-token of Huawei obs ends with =, so JfsSetting.ParseFormatOptions method verification will make an error, code show as below, len(pair) will be 3:

juicefs-csi-driver/pkg/config/setting.go

Lines 370 to 390 in 80bc0f6

	func (s *JfsSetting) ParseFormatOptions() ([][]string, error) {
	options := strings.Split(s.FormatOptions, ",")
	parsedFormatOptions := make([][]string, 0, len(options))
	for _, option := range options {
	pair := strings.Split(strings.TrimSpace(option), "=")
	if len(pair) != 1 && len(pair) != 2 {
	return nil, fmt.Errorf("invalid format options: %s", s.FormatOptions)
	}
	key := strings.TrimSpace(pair[0])
	if key == "" {
	// ignore empty key
	continue
	}
	value := ""
	if len(pair) == 2 {
	value = strings.TrimSpace(pair[1])
	}
	parsedFormatOptions = append(parsedFormatOptions, []string{key, value})
	}
	return parsedFormatOptions, nil
	}

Anything else we need to know?

Environment:

• JuiceFS CSI Driver version (which image tag did your CSI Driver use):
• Kubernetes version (e.g. kubectl version):
• Object storage (cloud provider and region):
• Metadata engine info (version, cloud provider managed or self maintained):
• Network connectivity (JuiceFS to metadata engine, JuiceFS to object storage):
• Others:

[showjason]

/assign

[showjason]

Hi @jianghushinian, maybe you can try the following secret yaml(but I'm not sure whether it will be working, that's my guess):)

apiVersion: v1
kind: Secret
metadata:
  name: juicefs-secret
  namespace: kube-system
type: Opaque
stringData:
  name: juicefs-test
  metaurl: redisurl
  storage: obs
  bucket: obs-bucket
  access-key: ak
  secret-key: sk
  session-token: xxxxxxx=

[Hexilee]

closed by #786