Use request.user.is_authenticated as a bool with recent Django #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django 1.10 changed request.user.is_authenticated from a function to a boolean and Django 2.0 dropped the backward compatibility. In order to use django-oidc-provider with Django 2.0, AuthorizeView needs to handle request.user.is_authenticated as a boolean.
psavoie
approved these changes
Dec 13, 2017
fishilico
added a commit
to Polytechnique-org/xorgauth
that referenced
this pull request
Jan 5, 2018
The last release of django-oidc-provider (0.5.2) was not compatible with Django 2.0. A fix has been integrated upstream (juanifioren/django-oidc-provider#216) but no released version of django-oidc-provider comes with it yet. Wait for such a release by marking Django 2.0 as unsupported for now in the setup.py requirements, event with Python 3.
suutari-ai
added a commit
to suutari-ai/django-oidc-provider
that referenced
this pull request
May 23, 2018
* 'develop' of github.com:juanifioren/django-oidc-provider: Update changelog.rst include request in password grant authenticate call Update setup.py Update changelog.rst Update changelog.rst Adjust import order and method order in introspection tests Replace resource with client in docs. Update settings docs to add extra introspection setting Update README.md Update README.md Remove the Resource model Skip csrf protection on introspection endpoint Add token introspection endpoint to satisfy https://tools.ietf.org/html/rfc7662 Test docs with tox. Remove Django 1.7 for travis. Drop support for Django 1.7. Move extract_client_auth to oauth2 utils. Remove duplicate link in docs. Bump version v0.6.0. Fix BaseCodeTokenModel and user attr. Update README.md Edit README and contribute doc. Edit changelog. Update changelog.rst Add protected_resource_view test using client_credentials. Fix docs. Improve docs. Client credentials implementation. Move changelog into docs. Update README.md Update CHANGELOG.md Fixed infinite callback loop in check-session iframe Fix PEP8. New migration. Update example project. Fix PEP8. Fix PEP8. PEP8 errors and urls. PEP8 models. Fix contribute docs. Fix tox for checking PEP8 all files. Update README.md Update README.md Simplify test suit. Update CHANGELOG.md Bump version 0.5.3. Update installation.rst Update CHANGELOG.md Fixed wrong Object in Template Update project to support Django 2.0 Now passing along the token to create_id_token function. Made token and token_refresh endpoint return requested claims. Sphinx documentation fixes (juanifioren#219) Use request.user.is_authenticated as a bool with recent Django (juanifioren#216) Fixed client id retrieval when aud is a list of str. (juanifioren#210) Add owner field to Client (juanifioren#211) Update CHANGELOG removed tab char Add pep8 compliance and checker Bump version Update CHANGELOG.md Preparing v0.5.2 (juanifioren#201) Fix Django 2.0 deprecation warnings (juanifioren#185) Fix infinite login loop if "prompt=login" (juanifioren#198) fixed typos Bump version Fix scope handling of token endpoint (juanifioren#193) Fixes juanifioren#192 Use stored user consent for public clients too (juanifioren#189) Redirect URIs must match exactly. (juanifioren#191) Bug juanifioren#187 prompt handling (juanifioren#188) Don't pin exact versions in install_requires.
schemen
added a commit
to schemen/django-easytz
that referenced
this pull request
Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django 1.10 changed
request.user.is_authenticatedfrom a function to a boolean and Django 2.0 dropped the backward compatibility. In order to use django-oidc-provider with Django 2.0,AuthorizeViewneeds to handlerequest.user.is_authenticatedas a boolean.