Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use request.user.is_authenticated as a bool with recent Django #216

Conversation

fishilico
Copy link
Contributor

Django 1.10 changed request.user.is_authenticated from a function to a boolean and Django 2.0 dropped the backward compatibility. In order to use django-oidc-provider with Django 2.0, AuthorizeView needs to handle request.user.is_authenticated as a boolean.

Django 1.10 changed request.user.is_authenticated from a function to a
boolean and Django 2.0 dropped the backward compatibility. In order to
use django-oidc-provider with Django 2.0, AuthorizeView needs to handle
request.user.is_authenticated as a boolean.
Copy link
Contributor

@reinout reinout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@wojtek-fliposports wojtek-fliposports merged commit 43d990c into juanifioren:develop Dec 14, 2017
@fishilico fishilico deleted the django-2.0-request-user-is_authenticated branch December 14, 2017 17:57
@fishilico fishilico restored the django-2.0-request-user-is_authenticated branch December 22, 2017 22:28
fishilico added a commit to Polytechnique-org/xorgauth that referenced this pull request Jan 5, 2018
The last release of django-oidc-provider (0.5.2) was not compatible with
Django 2.0. A fix has been integrated upstream
(juanifioren/django-oidc-provider#216) but no
released version of django-oidc-provider comes with it yet.

Wait for such a release by marking Django 2.0 as unsupported for now in
the setup.py requirements, event with Python 3.
suutari-ai added a commit to suutari-ai/django-oidc-provider that referenced this pull request May 23, 2018
* 'develop' of github.com:juanifioren/django-oidc-provider:
  Update changelog.rst
  include request in password grant authenticate call
  Update setup.py
  Update changelog.rst
  Update changelog.rst
  Adjust import order and method order in introspection tests
  Replace resource with client in docs.
  Update settings docs to add extra introspection setting
  Update README.md
  Update README.md
  Remove the Resource model
  Skip csrf protection on introspection endpoint
  Add token introspection endpoint to satisfy https://tools.ietf.org/html/rfc7662
  Test docs with tox.
  Remove Django 1.7 for travis.
  Drop support for Django 1.7.
  Move extract_client_auth to oauth2 utils.
  Remove duplicate link in docs.
  Bump version v0.6.0.
  Fix BaseCodeTokenModel and user attr.
  Update README.md
  Edit README and contribute doc.
  Edit changelog.
  Update changelog.rst
  Add protected_resource_view test using client_credentials.
  Fix docs.
  Improve docs.
  Client credentials implementation.
  Move changelog into docs.
  Update README.md
  Update CHANGELOG.md
  Fixed infinite callback loop in check-session iframe
  Fix PEP8. New migration.
  Update example project.
  Fix PEP8.
  Fix PEP8.
  PEP8 errors and urls.
  PEP8 models.
  Fix contribute docs.
  Fix tox for checking PEP8 all files.
  Update README.md
  Update README.md
  Simplify test suit.
  Update CHANGELOG.md
  Bump version 0.5.3.
  Update installation.rst
  Update CHANGELOG.md
  Fixed wrong Object in Template
  Update project to support Django 2.0
  Now passing along the token to create_id_token function.
  Made token and token_refresh endpoint return requested claims.
  Sphinx documentation fixes (juanifioren#219)
  Use request.user.is_authenticated as a bool with recent Django (juanifioren#216)
  Fixed client id retrieval when aud is a list of str. (juanifioren#210)
  Add owner field to Client (juanifioren#211)
  Update CHANGELOG
  removed tab char
  Add pep8 compliance and checker
  Bump version
  Update CHANGELOG.md
  Preparing v0.5.2 (juanifioren#201)
  Fix Django 2.0 deprecation warnings (juanifioren#185)
  Fix infinite login loop if "prompt=login" (juanifioren#198)
  fixed typos
  Bump version
  Fix scope handling of token endpoint (juanifioren#193)
  Fixes juanifioren#192
  Use stored user consent for public clients too (juanifioren#189)
  Redirect URIs must match exactly. (juanifioren#191)
  Bug juanifioren#187 prompt handling (juanifioren#188)
  Don't pin exact versions in install_requires.
schemen added a commit to schemen/django-easytz that referenced this pull request Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants