improve errors for missing directories #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kradalby
force-pushed
the
var-run-docker
branch
2 times, most recently
from
4a6ff00 to
c1e1df8
Compare
This was
linked to
issues
Feb 16, 2024
juanfont
previously approved these changes
Feb 17, 2024
Fixes juanfont#1761 Updates juanfont#1760 Signed-off-by: Kristoffer Dalby <[email protected]>
Signed-off-by: Kristoffer Dalby <[email protected]>
Signed-off-by: Kristoffer Dalby <[email protected]>
kradalby
dismissed
juanfont’s stale review
The merge-base changed after approval.
kradalby
force-pushed
the
var-run-docker
branch
from
c1e1df8 to
97312eb
Compare
juanfont
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new docker image does not have all headscale directories pre-created, and while 99% of the cases, these dirs should be mounted into the container and therefore created, it might be a source of confusion.
This commit improves the error messages for these cases.
Depends on a changelog update after #1763