Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework docker tags #1763

Merged
merged 2 commits into from
Feb 17, 2024
Merged

rework docker tags #1763

merged 2 commits into from
Feb 17, 2024

Conversation

kradalby
Copy link
Collaborator

@kradalby kradalby commented Feb 16, 2024

This commit tries to align the new docker tags with the old schema

A prerelease will end up with the following tags:

  • unstable
  • v0.23.0-alpha3
  • 0.23.0-alpha3
  • sha-1234adsfg

A release will end up with:

  • latest
  • stable
  • v0.23.0
  • v0.23
  • v0
  • 0.23.0
  • 0.23
  • 0
  • sha-1234adsfg

All of the builds will also have a -debug version.

I think this addresses the feedback from discord and #1561 (comment).

This commit tries to align the new docker tags with the old schema

A prerelease will end up with the following tags:

- unstable
- v0.23.0-alpha3
- 0.23.0.alpha3
- sha-1234adsfg

A release will end up with:

- latest
- stable
- v0.23.0
- v0.23
- v0
- 0.23.0
- 0.23
- 0
- sha-1234adsfg

All of the builds will also have a `-debug` version.

Signed-off-by: Kristoffer Dalby <[email protected]>
@kradalby kradalby requested a review from juanfont February 16, 2024 07:33
@kradalby
Copy link
Collaborator Author

@ohdearaugustin please sanity check.

Signed-off-by: Kristoffer Dalby <[email protected]>
Copy link
Collaborator

@ohdearaugustin ohdearaugustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me

@ohdearaugustin
Copy link
Collaborator

I guess we have to manually fix the tags from the last release.

@kradalby kradalby merged commit 1904d79 into juanfont:main Feb 17, 2024
51 checks passed
@vbrandl
Copy link

vbrandl commented Feb 22, 2024

Currently there is no latest tag at https://hub.docker.com/r/headscale/headscale/tags. Will this tag be created with the next proper release?

@kradalby
Copy link
Collaborator Author

Likely, but we might avoid it as it is quite bad practise to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.23.0 image tag available on Docker but not on project
4 participants