-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include eslint@9 in peerDependencies #994
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #994 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 107 107
Lines 1651 1651
Branches 581 581
=======================================
Hits 1635 1635
Misses 16 16 ☔ View full report in Codecov by Sentry. |
That's not sufficient to support eslint 9; see #978. Please leave this PR open, since I'll now have to repurpose it when eslint 9 support is actually possible. In the meantime, simply do not yet upgrade to eslint 9, until all of your plugins support it explicitly. |
With the publication of the version v6.9.0, is it now possible to include eslint@9 in peerDependencies? |
@andreyevyk nope, not yet, see #978. |
@ljharb what about now? |
This is already covered by #1009 |
@michaelfaith true 🤦 I think it's time for me to go to bed |
Indeed; obsoleted by #1009. |
v6.9.0 supports Flat Config, but an error occurs during installation because peerDependencies does not include eslint@9. This PR adds "^9" to peerDependencies.