[New] add eslint 9 support #1009

michaelfaith · 2024-08-30T17:57:12Z

This change adds support for eslint v9. All three example projects have been updated to use the latest eslint, and the root package's dev and peer deps have been updated.

In order to make this work with both v9 and older versions, I had to update the parser options helper to adjust the config passed into the RuleTester. It was also necessary update jest to a newer version, in order to resolve eslint's use of node:fs/promises.

Note: the removed test cases are exact duplicates of other tests. v9 fails tests when its determined to be an exact duplicate.

Closes: #978

This change adds support for eslint v9. All three example projects have been updated to use the latest eslint, and the root package's dev and peer deps have been updated. In order to make this work with both v9 and older versions, I had to update the parser options helper to adjust the config passed into the `RuleTester`.

package.json

__tests__/src/rules/no-static-element-interactions-test.js

ljharb · 2024-08-30T18:09:20Z

package.json

-    "jest": "^24.9.0",
+    "jest": "^29.7.0",


we can't upgrade jest, because jest 24 is the last version that supports node 6.

Hmm. Ok, but jest 24 isn't able to resolve node:fs/promises which eslint uses (so we hit this when importing RuleTester from eslint). I could map node:fs/promises to something like fs-extra using jest's moduleNameMapper? So the project is never going higher than jest 24?

at some point we'll have a breaking change that drops older eslints/nodes, but i'm more likely to bail on jest entirely and use something less frictiony regardless.

can you map node:fs/promises to fs/promises, instead? the node: prefix is pretty useless.

After a few iterations, I got it working. I ended up having to map several built in node modules, as well as a couple of esm entry points of eslint packages, I also had to add a polyfill for structuredClone, which eslint uses as part of RuleTester and was added in node 17.

Everything's green now, if you want to take another look when you have the time. It may be worth considering dynamically installing a newer jest for v9 and removing all of those workarounds (in the same way each eslint version is being installed), but I'll leave that to you.

socket-security · 2024-08-31T12:46:32Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@eslint/[email protected]	None	`0`	14.2 kB	eslintbot
npm/[email protected]	None	`0`	1.24 MB	zloirock
npm/[email protected]	environment Transitive: eval, filesystem, shell, unsafe	`+88`	9.91 MB	eslintbot
npm/[email protected]	None	`0`	174 kB	sindresorhus

View full report↗︎

codecov · 2024-08-31T19:30:54Z

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.73%. Comparing base (a08fbcc) to head (1231f61).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
__tests__/__util__/parserOptionsMapper.js	87.50%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1009      +/-   ##
==========================================
- Coverage   99.03%   98.73%   -0.30%     
==========================================
  Files         107      107              
  Lines        1660     1666       +6     
  Branches      588      591       +3     
==========================================
+ Hits         1644     1645       +1     
- Misses         16       21       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

__tests__/__util__/nodeReexports/assert.js

package.json

ljharb

Seems good!

ljharb · 2024-09-04T07:20:16Z

it's now released; v6.10.0.

ruiaraujo012 · 2024-09-12T18:31:15Z

@ljharb I think something is missing, there's no v6.10.0 release, there is a tag but not a release.

ljharb · 2024-09-12T19:02:54Z

oh thanks, i always forget github releases (which don't matter; only npm matters)

ruiaraujo012 · 2024-09-12T19:09:14Z

Oh, you're right, I didn't check npm 🙈 sorry.

> [!WARNING] > **Breaking Change:** Now uses `[email protected]` which has a new violation disallowing Component names starting with anything but an uppercase letter. See https://github.com/facebook/react/releases/tag/eslint-plugin-react-hooks%405.0.0 for more details. Adds support of ESLint v9 to `eslint-plugin-next`, `eslint-config-next` and `next lint`. Does not require using the new flat config format. `next lint` will automatically ensure the old config format can be used. ### Why? As `eslint-plugin-react-hooks` has been updated for ESLint v9 support and is a helpful package for Next v15 upgrade, unblock the restrictions to upgrade to ESLint v9. Also, ESLint v8 is [End of Life](https://eslint.org/blog/2024/09/eslint-v8-eol-version-support/#:~:text=ESLint%20v8.-,x%20end%20of%20life%20is%20October%205%2C%202024,x%20on%20October%205%2C%202024.) support since Oct 5th, so is good to unblock v9 now. Plugins bumped: - [x] [@rushstack/eslint-patch](microsoft/rushstack#4719) ([v1.10.3](https://www.npmjs.com/package/@rushstack/eslint-patch/v/1.10.3?activeTab=versions) no release post, confirmed on NPM) - [x] [@typescript-eslint/eslint-plugin](typescript-eslint/typescript-eslint#9002) ([v8.0.0](typescript-eslint/typescript-eslint#9002 (comment))) - [x] [eslint-plugin-import](import-js/eslint-plugin-import#2996) ([v2.31.0](https://github.com/import-js/eslint-plugin-import/releases/tag/v2.31.0)) - [x] [eslint-plugin-jsx-a11y](jsx-eslint/eslint-plugin-jsx-a11y#1009) ([v6.10.0](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/releases/tag/v6.10.0)) - [x] [eslint-plugin-react](jsx-eslint/eslint-plugin-react#3759) ([v7.35.0](https://github.com/jsx-eslint/eslint-plugin-react/releases/tag/v7.35.0)) - [x] [eslint-plugin-react-hooks](facebook/react#28773) ([v5.0.0](https://github.com/facebook/react/releases/tag/eslint-plugin-react-hooks%405.0.0)) We have to switch to ESLint v9 in our repo due to a pnpm bug where it automatically uses ESLint v9 even though we only installed it via `eslint-v9: npm:[email protected]`. This is a pnpm bug that wouldn't happen with Yarn v1, v4 nor NPM. Closes #64409 Closes #64114 Closes #64453 Closes NEXT-3293 --------- Co-authored-by: Sebastian "Sebbie" Silbermann <[email protected]>

michaelfaith added 2 commits July 18, 2024 06:15

[Tests] remove duplicate tests

74d5dec

michaelfaith mentioned this pull request Aug 30, 2024

📈 Tracking: ESLint v9 support eslint/eslint#18391

Open

7 tasks

michaelfaith commented Aug 30, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

ljharb requested changes Aug 30, 2024

View reviewed changes

michaelfaith force-pushed the feat/eslint-v9-support branch 8 times, most recently from 3db1f8c to 4f21b85 Compare August 31, 2024 12:46

michaelfaith force-pushed the feat/eslint-v9-support branch 2 times, most recently from f99300c to 1231f61 Compare August 31, 2024 19:20

ljharb reviewed Sep 1, 2024

View reviewed changes

__tests__/__util__/nodeReexports/assert.js Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

package.json Show resolved Hide resolved

michaelfaith force-pushed the feat/eslint-v9-support branch 3 times, most recently from f8e70cd to 903bca2 Compare September 1, 2024 17:13

burtek mentioned this pull request Sep 1, 2024

feat!: Upgrade to ESLint v9 burtek/eslint-config#65

Merged

13 tasks

ljharb changed the title ~~build: update to eslint v9~~ [New] add eslint 9 support Sep 1, 2024

ljharb added the enhancement label Sep 1, 2024

ljharb approved these changes Sep 1, 2024

View reviewed changes

ljharb mentioned this pull request Sep 1, 2024

eslint v9 support airbnb/javascript#2961

Open

14 tasks

ljharb force-pushed the feat/eslint-v9-support branch from 903bca2 to deac4fd Compare September 1, 2024 21:42

ljharb merged commit deac4fd into jsx-eslint:main Sep 1, 2024
105 checks passed

michaelfaith deleted the feat/eslint-v9-support branch September 1, 2024 22:42

michaelfaith mentioned this pull request Sep 2, 2024

include eslint@9 in peerDependencies #994

Closed

Luis-Kristen mentioned this pull request Sep 25, 2024

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.2.3 to 6.10.0 Luis-Kristen/feature-react#198

Open

alhugot-azpn mentioned this pull request Sep 25, 2024

security(snyk): upgrade eslint-plugin-jsx-a11y from 6.9.0 to 6.10.0 emerson-eps/eslint-config#260

Merged

This was referenced Sep 25, 2024

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.6.0 to 6.10.0 SuperSuperDev/crystal-crypto-prices-sei-project-2#211

Open

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.6.0 to 6.10.0 SuperSuperDev/crystal-crypto-prices-sei-project-2#216

Open

DadonStyle mentioned this pull request Sep 26, 2024

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.5.1 to 6.10.0 DadonStyle/Crypto-Tower-FE#10

Open

SuperSuperDev mentioned this pull request Sep 28, 2024

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.6.0 to 6.10.0 SuperSuperDev/crystal-crypto-prices-sei-project-2#221

Open

DadonStyle mentioned this pull request Sep 28, 2024

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.5.1 to 6.10.0 DadonStyle/Crypto-Tower-FE#18

Open

SuperSuperDev mentioned this pull request Oct 1, 2024

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.6.0 to 6.10.0 SuperSuperDev/crystal-crypto-prices-sei-project-2#226

Open

DadonStyle mentioned this pull request Oct 1, 2024

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.5.1 to 6.10.0 DadonStyle/Crypto-Tower-FE#22

Open

This was referenced Oct 2, 2024

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.6.0 to 6.10.0 SuperSuperDev/crystal-crypto-prices-sei-project-2#231

Open

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.6.0 to 6.10.0 SuperSuperDev/crystal-crypto-prices-sei-project-2#236

Open

DadonStyle mentioned this pull request Oct 3, 2024

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.5.1 to 6.10.0 DadonStyle/Crypto-Tower-FE#27

Open

This was referenced Oct 3, 2024

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.4.1 to 6.10.0 ManuelDevWeb/platziVideoReact#334

Open

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.4.1 to 6.10.0 ManuelDevWeb/platziVideoReactRouterYRedux#335

Open

DadonStyle mentioned this pull request Oct 4, 2024

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.5.1 to 6.10.0 DadonStyle/Crypto-Tower-FE#32

Open

SuperSuperDev mentioned this pull request Oct 4, 2024

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.6.0 to 6.10.0 SuperSuperDev/crystal-crypto-prices-sei-project-2#241

Open

qdraw mentioned this pull request Oct 4, 2024

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.9.0 to 6.10.0 qdraw/starsky#1750

Closed

neil-morrison44 mentioned this pull request Oct 13, 2024

New 'negative lookbehind' regex breaks in IOS & Safari versions < 16.4 syntax-tree/mdast-util-gfm-autolink-literal#10

Closed

4 tasks

devjiwonchoi mentioned this pull request Oct 13, 2024

[BREAKING] Support ESLint v9 in plugin, config and next lint vercel/next.js#71218

Merged

6 tasks

This was referenced Oct 25, 2024

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.4.1 to 6.10.0 ManuelDevWeb/platziVideoReactRouterYRedux#340

Open

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.4.1 to 6.10.0 ManuelDevWeb/platziVideoReact#340

Open

This was referenced Oct 27, 2024

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.5.1 to 6.10.0 DadonStyle/Crypto-Tower-FE#38

Open

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.5.1 to 6.10.0 DadonStyle/Crypto-Tower-FE#43

Open

SuperSuperDev mentioned this pull request Nov 5, 2024

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.6.0 to 6.10.0 SuperSuperDev/crystal-crypto-prices-sei-project-2#246

Open

Luis-Kristen mentioned this pull request Nov 7, 2024

[Snyk] Upgrade eslint-plugin-jsx-a11y from 6.2.3 to 6.10.0 Luis-Kristen/feature-react#208

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[New] add eslint 9 support #1009

[New] add eslint 9 support #1009

michaelfaith commented Aug 30, 2024

ljharb Aug 30, 2024

michaelfaith Aug 30, 2024 •

edited

Loading

ljharb Aug 30, 2024

michaelfaith Aug 30, 2024 •

edited

Loading

This comment was marked as off-topic.

michaelfaith Aug 31, 2024 •

edited

Loading

socket-security bot commented Aug 31, 2024 •

edited

Loading

codecov bot commented Aug 31, 2024 •

edited

Loading

ljharb left a comment

ljharb commented Sep 4, 2024

ruiaraujo012 commented Sep 12, 2024 •

edited

Loading

ljharb commented Sep 12, 2024

ruiaraujo012 commented Sep 12, 2024

[New] add eslint 9 support #1009

[New] add eslint 9 support #1009

Conversation

michaelfaith commented Aug 30, 2024

ljharb Aug 30, 2024

Choose a reason for hiding this comment

michaelfaith Aug 30, 2024 • edited Loading

Choose a reason for hiding this comment

ljharb Aug 30, 2024

Choose a reason for hiding this comment

michaelfaith Aug 30, 2024 • edited Loading

Choose a reason for hiding this comment

This comment was marked as off-topic.

michaelfaith Aug 31, 2024 • edited Loading

Choose a reason for hiding this comment

socket-security bot commented Aug 31, 2024 • edited Loading

codecov bot commented Aug 31, 2024 • edited Loading

Codecov Report

ljharb left a comment

Choose a reason for hiding this comment

ljharb commented Sep 4, 2024

ruiaraujo012 commented Sep 12, 2024 • edited Loading

ljharb commented Sep 12, 2024

ruiaraujo012 commented Sep 12, 2024

michaelfaith Aug 30, 2024 •

edited

Loading

michaelfaith Aug 30, 2024 •

edited

Loading

michaelfaith Aug 31, 2024 •

edited

Loading

socket-security bot commented Aug 31, 2024 •

edited

Loading

codecov bot commented Aug 31, 2024 •

edited

Loading

ruiaraujo012 commented Sep 12, 2024 •

edited

Loading