Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jstzd): use poll in retry #681

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

huancheng-trili
Copy link
Collaborator

Context

Following #645.

Description

Reuse poll in retry since they do very similar things. Also added some tests for these two functions.

Manually testing the PR

  • Unit test: added new test cases

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 90.80460% with 8 lines in your changes missing coverage. Please review.

Project coverage is 46.98%. Comparing base (db88c9e) to head (773c507).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/jstzd/src/task/utils.rs 90.80% 0 Missing and 8 partials ⚠️
Files with missing lines Coverage Δ
crates/jstzd/src/task/utils.rs 91.57% <90.80%> (+5.86%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db88c9e...773c507. Read the comment docs.

@huancheng-trili huancheng-trili marked this pull request as ready for review November 21, 2024 12:33
@zcabter zcabter assigned huancheng-trili and unassigned zcabter Nov 27, 2024
Base automatically changed from huanchengchang-jstz-145 to main November 28, 2024 11:27
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-145-1 branch from 557f781 to 773c507 Compare November 28, 2024 11:28
@huancheng-trili huancheng-trili merged commit 65e9bf6 into main Nov 28, 2024
5 checks passed
@huancheng-trili huancheng-trili deleted the huanchengchang-jstz-145-1 branch November 28, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants