-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(octez): implement execute_rollup_outbox_message #645
Conversation
8c7d268
to
e6053c0
Compare
Codecov ReportAttention: Patch coverage is
Continue to review full report in Codecov by Sentry.
|
e6053c0
to
7254af3
Compare
hi could you rebase and i can take a look :) |
2875297
to
afa32ef
Compare
dd9aaff
to
6a7a3b0
Compare
6719bcb
to
fe78314
Compare
6a7a3b0
to
61d0d62
Compare
Logic of the actual |
61d0d62
to
e5d0b90
Compare
e5d0b90
to
db33dfa
Compare
Context
Completes JSTZ-145.
JSTZ-145
Description
Implement
execute_rollup_outbox_message
that performsoctez-client execute outbox message of smart rollup ...
.Manually testing the PR
Integration test: added one test. The setup is as follows:
int(x)
and does something.int(1)
targeting the contract to the outbox whenever an external message arrives at the inbox. This is adapted from the rollup gallery. Source file is included in this PR as well. Since there is no one else writing messages to the inbox and there is no other rollup running, it's safe to assume that the only outbox message is produced by this exact rollup based on the inbox messages sent by the only call tooctez-client write inbox message
in the test.The addresses and contract files are brand new and separated from existing parameter files in order to prevent unexpected changes to the contract files that affect the tests. Housekeeping will be done in a separate PR to organise other test files and keep the base test parameter template clean, i.e. bootstrap contracts and rollups should be injected with
ParameterBuilder
rather than hardcoded in the template.