Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(octez): implement execute_rollup_outbox_message #645

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

huancheng-trili
Copy link
Collaborator

@huancheng-trili huancheng-trili commented Nov 11, 2024

Context

Completes JSTZ-145.

JSTZ-145

Description

Implement execute_rollup_outbox_message that performs octez-client execute outbox message of smart rollup ....

Manually testing the PR

  • Integration test: added one test. The setup is as follows:

    • contract: takes input int(x) and does something.
    • rollup: writes a message int(1) targeting the contract to the outbox whenever an external message arrives at the inbox. This is adapted from the rollup gallery. Source file is included in this PR as well. Since there is no one else writing messages to the inbox and there is no other rollup running, it's safe to assume that the only outbox message is produced by this exact rollup based on the inbox messages sent by the only call to octez-client write inbox message in the test.

    The addresses and contract files are brand new and separated from existing parameter files in order to prevent unexpected changes to the contract files that affect the tests. Housekeeping will be done in a separate PR to organise other test files and keep the base test parameter template clean, i.e. bootstrap contracts and rollups should be injected with ParameterBuilder rather than hardcoded in the template.

@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-145 branch 3 times, most recently from 8c7d268 to e6053c0 Compare November 11, 2024 10:55
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.68%. Comparing base (24324a0) to head (db33dfa).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
crates/octez/src/async/client.rs 91.42% 0 Missing and 3 partials ⚠️
Files with missing lines Coverage Δ
crates/jstzd/src/task/octez_rollup.rs 82.19% <100.00%> (+0.76%) ⬆️
crates/octez/src/async/client.rs 89.27% <91.42%> (+0.10%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24324a0...db33dfa. Read the comment docs.

@huancheng-trili huancheng-trili marked this pull request as ready for review November 11, 2024 12:15
Base automatically changed from huanchengchang-jstz-144 to main November 12, 2024 12:11
@ryutamago
Copy link
Collaborator

hi could you rebase and i can take a look :)

@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-145 branch 2 times, most recently from 2875297 to afa32ef Compare November 15, 2024 09:44
@huancheng-trili huancheng-trili changed the base branch from main to huan/revise-baker-test November 15, 2024 09:57
@huancheng-trili huancheng-trili removed their assignment Nov 18, 2024
@huancheng-trili huancheng-trili force-pushed the huan/revise-baker-test branch 2 times, most recently from 6719bcb to fe78314 Compare November 19, 2024 16:45
Base automatically changed from huan/revise-baker-test to main November 19, 2024 17:11
@zcabter zcabter assigned huancheng-trili and unassigned zcabter Nov 20, 2024
@zcabter
Copy link
Collaborator

zcabter commented Nov 20, 2024

Logic of the actual execute_rollup_outbox_message function looks good

@zcabter zcabter assigned huancheng-trili and unassigned zcabter Nov 27, 2024
@huancheng-trili huancheng-trili merged commit db88c9e into main Nov 28, 2024
5 checks passed
@huancheng-trili huancheng-trili deleted the huanchengchang-jstz-145 branch November 28, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants