Replace defunct Travis CI integration with GitHub Actions #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitHub Actions setup is equivalent to the Travis CI configuration with two differences: - The GitHub Action setup does not set the `TAG` environment variable, as it didn't seem like `xml2rfc` would consume that at all (unless I'm missing something) - The GitHub Action preserves the spec output (txt and html) as artifacts that can be downloaded after a successful run (to see the changes without having to locally render the specs) Fixes: #1262 Signed-off-by: Juan Cruz Viotti <[email protected]>
|
@Relequestual I think you might need to enable the repository to run GitHub Actions from forks to be able to test this out. Once it is merged, we should also make this check required. |
|
What I've had to do in |
|
I believe this will also upload |
Relequestual
requested changes
Aug 15, 2022
Co-authored-by: Ben Hutton <[email protected]>
|
Good catch @Relequestual ! Fixed. |
Relequestual
approved these changes
Aug 19, 2022
|
I decided to merge this immediatly as our current CI simply doesn't work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub Actions setup is equivalent to the Travis CI configuration
with two differences:
The GitHub Action setup does not set the
TAGenvironment variable,as it didn't seem like
xml2rfcwould consume that at all (unless I'mmissing something)
The GitHub Action preserves the spec output (txt and html) as
artifacts that can be downloaded after a successful run (to see the
changes without having to locally render the specs)
Fixes: #1262
Signed-off-by: Juan Cruz Viotti [email protected]