Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check on and fix CI checks on spec repo #1262

Closed
Relequestual opened this issue Jul 22, 2022 · 2 comments · Fixed by #1266 or #1279
Closed

Check on and fix CI checks on spec repo #1262

Relequestual opened this issue Jul 22, 2022 · 2 comments · Fixed by #1266 or #1279
Assignees
@jviotti

Comments

@Relequestual
Copy link
Member

Relequestual commented Jul 22, 2022 •
edited
Loading

Action item from json-schema-org/community#200 - @jviotti

Our CI for this repo has not been running.
We should investigate what it was doing, define what we would like it to do, and (probably) resolve by using GitHub actions.

Related: #618
@jviotti jviotti mentioned this issue Aug 5, 2022
Merged
Relequestual pushed a commit that referenced this issue Aug 19, 2022
@jviotti @Relequestual
Replace defunct Travis CI integration with GitHub Actions
b4a2003 
The GitHub Actions setup is equivalent to the Travis CI configuration
with two differences:

- The GitHub Action setup does not set the `TAG` environment variable,
  as it didn't seem like `xml2rfc` would consume that at all (unless I'm
  missing something)

- The GitHub Action preserves the spec output (txt and html) as
  artifacts that can be downloaded after a successful run (to see the
  changes without having to locally render the specs)

Fixes: #1262
Signed-off-by: Juan Cruz Viotti <[email protected]>
@Relequestual
Copy link
Member Author

The merged PR did not work as expected.
@jviotti see https://github.com/json-schema-org/json-schema-spec/runs/7915793140?check_suite_focus=true#step:6:9

@Relequestual Relequestual reopened this Aug 19, 2022
@Relequestual Relequestual linked a pull request Aug 19, 2022 that will close this issue
Fix artifact upload patterns. #1279
Merged
@Relequestual
Copy link
Member Author

Julian fixed it. Woop!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jviotti jviotti

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Relequestual @jviotti