Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Major Release] Remove jsk_pcl_ros/box_array_to_box.py #1833

Merged
merged 1 commit into from
Oct 27, 2016
Merged

[Major Release] Remove jsk_pcl_ros/box_array_to_box.py #1833

merged 1 commit into from
Oct 27, 2016

Conversation

wkentaro
Copy link
Member

@wkentaro wkentaro commented Aug 7, 2016

Close #1831
This change should be released as a major release.

cc @k-okada

@wkentaro wkentaro force-pushed the remove-box-array-to-box branch from 709ad83 to 88643f2 Compare August 7, 2016 15:29
@wkentaro wkentaro changed the title Remove jsk_pcl_ros/box_array_to_box.py [Major Release] Remove jsk_pcl_ros/box_array_to_box.py Aug 7, 2016
@wkentaro wkentaro mentioned this pull request Aug 7, 2016
Closed
@k-okada
Copy link
Member

k-okada commented Aug 8, 2016

why you removed imagesift

◉ Kei Okada

On Mon, Aug 8, 2016 at 12:10 AM, Kentaro Wada [email protected]
wrote:

Close #1831 #1831
This change should be released as a major release.

cc @k-okada https://github.com/k-okada

You can view, comment on, or merge this pull request online at:

#1833
Commit Summary

  • Remove jsk_pcl_ros/box_array_to_box.py

File Changes

Patch Links:

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1833, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAeG3G0k19paAYbMbaDH4ahMf2tYggnOks5qdfV7gaJpZM4JehLK
.

@wkentaro
Copy link
Member Author

wkentaro commented Aug 8, 2016

It is already fixed.

@wkentaro wkentaro force-pushed the remove-box-array-to-box branch from 88643f2 to 2945057 Compare August 20, 2016 09:01
@k-okada k-okada mentioned this pull request Aug 30, 2016
Closed
9 tasks
@k-okada
Copy link
Member

k-okada commented Aug 30, 2016

since no one claimed that this is used, but not sure if we're ok to remove this .... #1799

@wkentaro wkentaro force-pushed the remove-box-array-to-box branch from 2945057 to 8e76841 Compare September 1, 2016 15:49
@YuOhara YuOhara mentioned this pull request Sep 5, 2016
Merged
@k-okada
Copy link
Member

k-okada commented Sep 6, 2016

it seems we had users for box_array_to_box.py -> #1799 (comment)

@wkentaro wkentaro added this to the 0.4.0 milestone Sep 6, 2016
@wkentaro wkentaro force-pushed the remove-box-array-to-box branch from 8e76841 to 1865bfd Compare September 21, 2016 01:50
@wkentaro
Remove jsk_pcl_ros/box_array_to_box.py
a506bfe 
Close jsk-ros-pkg#1831
This change should be released as a major release.

cc @k-okada
@wkentaro wkentaro force-pushed the remove-box-array-to-box branch from 1865bfd to a506bfe Compare October 10, 2016 00:18
@k-okada k-okada merged commit ad741c8 into jsk-ros-pkg:master Oct 27, 2016
@wkentaro wkentaro deleted the remove-box-array-to-box branch October 27, 2016 12:15
wkentaro referenced this pull request Oct 30, 2016
@k-okada
0.3.27
c2203a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement pkg/jsk_pcl_ros PR/DoNotMergeYet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wkentaro @k-okada