Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test names in favor to {NODE_NAME}.test #1806

Merged
merged 2 commits into from
Aug 11, 2016
Merged

Fix test names in favor to {NODE_NAME}.test #1806

merged 2 commits into from
Aug 11, 2016

Conversation

wkentaro
Copy link
Member

No description provided.

@wkentaro wkentaro force-pushed the fix-test-names branch 5 times, most recently from 37f28b7 to e85db37 Compare August 5, 2016 15:59
@wkentaro
Copy link
Member Author

wkentaro commented Aug 6, 2016

Please merge this.

k-okada
k-okada reviewed Aug 7, 2016
View reviewed changes
jsk_pcl_ros_utils/CMakeLists.txt
if("$ENV{ROS_DISTRO}" STRGREATER "hydro")
# unexpected error
add_rostest(test/point_indices_to_mask_image.test)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add explanation about naming rules.

@wkentaro
Copy link
Member Author

Please merge this!

@k-okada
Copy link
Member

k-okada commented Aug 11, 2016

Is this so important and urgent ? to emphasis with bold and ! ? if so please write reasons.

@wkentaro
Copy link
Member Author

Is this so important and urgent ?

No.

to emphasis with bold and ! ?

It's just a template of my please_merge_this command, so I can change it.

@k-okada
Copy link
Member

k-okada commented Aug 11, 2016

I see, I thought you are falling to dark side
#1827 (comment)

On Thursday, 11 August 2016, Kentaro Wada [email protected] wrote:

Is this so important and urgent ?

No.

to emphasis with bold and ! ?

It's just a template of my please_merge_this command, so I can change it.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#1806 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAeG3PTOFqpfBioGOewLVay8hIn4KrZhks5qerIXgaJpZM4JY06o
.

◉ Kei Okada

@k-okada k-okada merged commit 5789ddf into jsk-ros-pkg:master Aug 11, 2016
@wkentaro wkentaro deleted the fix-test-names branch August 11, 2016 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement pkg/jsk_pcl_ros_utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkentaro @k-okada