Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc/jsk_perception] documentations for edge_detector and hough_circle_detector #1664

Closed
wants to merge 2 commits into from

Conversation

mizmizo
Copy link
Contributor

@mizmizo mizmizo commented May 13, 2016

wrote two documentations.
for #1648

@k-okada
Copy link
Member

k-okada commented May 13, 2016

http://wiki.ros.org/opencv_apps#edge_detection
はみてみた?こちらでいいなら,そっちを見ましょう,という風に書けば良いというつもりでした.

@mizmizo
Copy link
Contributor Author

mizmizo commented May 13, 2016

比較してみるとSubscribed Topics, Published Topicsは同じですが,Parametersの内容が大きく異なっているので新しく作った方が良いと思ったのですが,どちらの方が良いでしょうか.

@k-okada
Copy link
Member

k-okada commented May 14, 2016

説明がたりなかったですが,opencv_appsにあるもので代用できるなら,そっちをつかうようにして,
jsk_recognitoinのdocumentにはdeprecate use http:// .. instead
とかかけばいいのでは?といういみでした.
パラメータが足りなくて,それが必要なら,opencv_apps にPRをおくるのはどうでしょうか.

◉ Kei Okada

On Fri, May 13, 2016 at 9:49 PM, Hiroto MIZOHANA [email protected]
wrote:

比較してみるとSubscribed Topics, Published
Topicsは同じですが,Parametersの内容が大きく異なっているので新しく作った方が良いと思ったのですが,どちらの方が良いでしょうか.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#1664 (comment)

@mizmizo
Copy link
Contributor Author

mizmizo commented May 16, 2016

勘違いしていました。機能としては同じようなのでopencv_appsを使うように書きなおしてみます。

@knorth55 knorth55 changed the title documentations for edge_detector and hough_circle_detector [doc/jsk_perception] documentations for edge_detector and hough_circle_detector May 26, 2016
@iory
Copy link
Member

iory commented Jun 2, 2016

#1696
こちらで対応したのでcloseしていいかと思います.

@iory iory closed this Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants