[pr2eus_moveit] Add timeout arg for computing IK and increase timeout for test #438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, I added
timeout
arg to some functions ofrobot-moveit.l
and set thetimeout
in the travis test longer.This pull request aims to prevent the travis test failure of
pr2eus_moveit
, such as:https://travis-ci.org/github/jsk-ros-pkg/jsk_pr2eus/builds/674758416
https://travis-ci.org/github/jsk-ros-pkg/jsk_pr2eus/builds/686633237
These tests fail here:
jsk_pr2eus/pr2eus_moveit/test/test-pr2eus-moveit.l
Lines 208 to 214 in 867460f
Error messages are as follows:
In detail, I think the reason is that
:move-end-coords-plan
fails:move-end-coords-plan
tm-diff
becomes too short.The reason why the IK calculation sometimes fails may be that its
timeout
is short.In my environment, the IK calculation sometimes takes ~0.1 [s], but the default
timeout
is 0.05 [s] inrobot-moveit.l
.I checked the IK calculation execution time by this code.
https://github.com/ros-planning/moveit/blob/50e3c21081c03a106ac1157d8a8687710bcc0398/moveit_kinematics/kdl_kinematics_plugin/src/kdl_kinematics_plugin.cpp#L409-L410
The default
timeout
inrobot-moveit.l
:jsk_pr2eus/pr2eus_moveit/euslisp/robot-moveit.l
Line 173 in 867460f
I am not confident, but I believe this pull requests improve success rate of the travis test.
By the way, I also tried to use
attempts
field inmoveit_msgs/PositionIKRequest
, but this field seems to be unavailable now.moveit/moveit#1288