Dropbox api upgrade #302
Dropbox api upgrade #302
Conversation
because content is already a filpointer obj
|
Thanks, glad to hear you got it working. I think I'm going to remove the progress bar. Also things like |
|
I added one test according to the other patterns you used. for the progress bar: maybe based on setting? reason I added it was, that I'm compressing the files to upload and it's about 2.5GB for me. the uplink to dropbox makes 19MB/s so 2.5GB will take some time. to calm the user it felt good to have some signs of life showing :) - your decision :) I also would be interested in the reason of the test fail because, I'm considering switching my own projects to tox... let me know if there are any questions! |
|
Tic-toc...June 28, 2017 is very close now...Merging this PR is VERY urgent!! |
storages/backends/dropbox.py
Outdated
| @@ -59,6 +94,31 @@ def __init__(self, oauth2_access_token=None, root_path=None): | |||
| "'settings.DROPBOX_OAUTH2_TOKEN'.") | |||
| self.client = Dropbox(oauth2_access_token) | |||
|
|
|||
| def _chunked_upload(self, content, dest_path): | |||
| """use chunked upload session for large files. stolen from | |||
| https://goo.gl/4XV0yT""" | |||
There was a problem hiding this comment.
Use the full URL: https://stackoverflow.com/documentation/dropbox-api/409/
jschneier
force-pushed
the
dropbox-api-upgrade
branch
from
60e3c4b to
f819489
Compare
|
any news? |
|
Deadline moved to September 28th, 2017: https://blogs.dropbox.com/developers/2017/06/updated-api-v1-deprecation-timeline/ We have a little more time, but this issue has to be fixed ASAP, please! EDIT: Sorry @jschneier, I didn't notice the change was already implemented with release 1.6! So maybe better to close this PR to avoid confusion...Thanks! |
|
@scps950707 @zuck the API upgrade is done (in master), the only thing missing from this PR is the large files upload. |
|
All of these are now fixed in master. |
adressing #301
tests not proven as #227#issuecomment-298834277
but backup worked for me