Dropbox storage throws an exception when saving a file

[maxmalysh]

Dropbox storage backend throws an exception when saving a file. I guess it stopped working after the API upgrade (see e46f306 and #302).

How to reproduce:

$ touch foo.txt
$ echo "hello, world" >> foo.txt
$ python3 manage.py shell
>>> from storages.backends.dropbox import DropBoxStorage
>>> dropbox_key = 'OAUTH_ACCESS_TOKEN'
>>> dropbox_storage = DropBoxStorage(dropbox_key)
>>> 
>>> f = open('foo.txt', 'rb')
>>> dropbox_storage.save('foo.txt', f)

Traceback (most recent call last):
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/code.py", line 91, in runcode
    exec(code, self.locals)
  File "<console>", line 1, in <module>
  File "/[...]/venv/lib/python3.5/site-packages/django/core/files/storage.py", line 54, in save
    return self._save(name, content)
  File "/[...]/venv/lib/python3.5/site-packages/storages/backends/dropbox.py", line 111, in _save
    self.client.files_upload(content, self._full_path(name))
  File "/[...]/venv/lib/python3.5/site-packages/dropbox/base.py", line 1267, in files_upload
    f,
  File "/[...]/venv/lib/python3.5/site-packages/dropbox/dropbox.py", line 234, in request
    timeout=timeout)
  File "/[...]/venv/lib/python3.5/site-packages/dropbox/dropbox.py", line 325, in request_json_string_with_retry
    timeout=timeout)
  File "/[...]/venv/lib/python3.5/site-packages/dropbox/dropbox.py", line 369, in request_json_string
    type(request_binary))
TypeError: expected request_binary as binary type, got <class 'django.core.files.base.File'>

I've already found the bug: DropBoxStorage._save receives a File or any file-like object (passed as the content argument), and then passes it straight to the self.client.files_upload method. However, DropboxBase.files_upload accepts only bytes.

I'll provide a pull request fixing both this and #301, if you don't mind.

[jschneier]

Please do, thanks.

…

On Wed, Aug 9, 2017 at 5:46 PM, Max Malysh ***@***.***> wrote: Dropbox storage backend throws an exception when saving a file. I guess it stopped working after the API upgrade (see e46f306 <e46f306> and #302 <#302>). How to reproduce: $ touch foo.txt $ echo "hello, world" >> foo.txt $ python3 manage.py shell >>> from storages.backends.dropbox import DropBoxStorage >>> dropbox_key = 'OAUTH_ACCESS_TOKEN' >>> dropbox_storage = DropBoxStorage(dropbox_key) >>> >>> f = open('foo.txt') >>> dropbox_storage.save('foo.txt', f) Traceback (most recent call last): File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/code.py", line 91, in runcode exec(code, self.locals) File "<console>", line 1, in <module> File "/[...]/venv/lib/python3.5/site-packages/django/core/files/storage.py", line 54, in save return self._save(name, content) File "/[...]/venv/lib/python3.5/site-packages/storages/backends/dropbox.py", line 111, in _save self.client.files_upload(content, self._full_path(name)) File "/[...]/venv/lib/python3.5/site-packages/dropbox/base.py", line 1267, in files_upload f, File "/[...]/venv/lib/python3.5/site-packages/dropbox/dropbox.py", line 234, in request timeout=timeout) File "/[...]/venv/lib/python3.5/site-packages/dropbox/dropbox.py", line 325, in request_json_string_with_retry timeout=timeout) File "/[...]/venv/lib/python3.5/site-packages/dropbox/dropbox.py", line 369, in request_json_string type(request_binary)) TypeError: expected request_binary as binary type, got <class 'django.core.files.base.File'> I've already found the bug: DropBoxStorage._save receives a File or any file-like object (as the content argument), and then passes it straight to the self.client.files_upload method. However, DropboxBase.files_upload accepts only bytes. I'll provide a pull request fixing both this and #301 <#301>, if you don't mind. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#378>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACJB2F18GqX0yuWPeYd6OGAgoo7K7iLdks5sWlL8gaJpZM4Oyz6n> .

[lucasrcezimbra]

Has this fix already been released? Or do you have a date forecast to release?

Thanks.

[flyalex]

@Lrcezimbra make:
pip uninstall django-storages
pip install -e 'git+https://github.com/jschneier/django-storages.git#egg=django-storages'

[lucasrcezimbra]

@flyalex I'm using like this, thanks!