Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CustomEvent from events #218

Closed
jscastro76 opened this issue Apr 3, 2021 · 0 comments
Closed

Remove CustomEvent from events #218

jscastro76 opened this issue Apr 3, 2021 · 0 comments
Assignees
@jscastro76
Labels
📑 code improvement 🔗 external dependencies
Milestone
v2.2.1.

Comments

@jscastro76
Copy link
Owner

Due to the moving to Three.js v127, the use of CustomEvent to dispatch the event to the handlers is producing errors in the console

Uncaught TypeError: Cannot set property target of #<Event> which has only a getter

These errors were probably being produced before but managed by Threejs, now they are rised and break the execution thread. To replace CustomEvent they will be replaced by the standard events that THREE.EventDispatcher recommends.

To keep compatibility, the events will be using detail to contain the same objects that were raised before.

WARNING: With this change we will lose Bubble and Cancel attributes
@jscastro76 jscastro76 added this to the v2.2.1. milestone Apr 3, 2021
@jscastro76 jscastro76 self-assigned this Apr 3, 2021
jscastro76 added a commit that referenced this issue Apr 3, 2021
@jscastro76
## 2.2.1
a2fb805 
Minor version by [@jscastro76](https://github.com/jscastro76), some enhancements and bugs.

#### ✨ Enhancements
- #212 Allow to remove an object by name
- #211 Create an object property that changes all the materials by a color
- #169 Update to Three.js v127
  - #214 Full refactor of tb.tube
  - #215 Refactor tb.line
  - #216 Refactor tb.update
  - #217 utils.material should allow THREE.DoubleSide
  - #218 Remove CustomEvent from events
  - #219 Remove .getInverse()
  - #220 Update Loaders
  - #221 Add fflate module

#### 🪲 Bug fixes
- #222 fflate depends on a physical file

#### 📝 Documentation
- Updated [documentation](/docs/Threebox.md) (`obj.color`, `tb.removeByName`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jscastro76 jscastro76

Labels
📑 code improvement 🔗 external dependencies
Projects
None yet
Milestone
v2.2.1.
Development

No branches or pull requests
1 participant
@jscastro76