Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Three.js 127 #169

Closed
9 tasks done
jscastro76 opened this issue Jan 13, 2021 · 2 comments
Closed
9 tasks done

Update to Three.js 127 #169

jscastro76 opened this issue Jan 13, 2021 · 2 comments
Assignees
@jscastro76
Labels
📑 code improvement 🔗 external dependencies 🔍 needs investigation
Milestone
v2.2.1.

Comments

@jscastro76
Copy link
Owner

jscastro76 commented Jan 13, 2021 •
edited
Loading

Some issues already detected:

  • Despite some demos work as is, without any change, demos with only one object the object (i.e. 01-basic.html) is loaded but suddenly disappear. It requires investigation because with 2 objects it doesn't happen.
  • evented.js:140 Error: THREE.Geometry is not a constructor buffergeometry
  • The bug ('duplicate()' Function Bug #16) on the duplicate has been solved.
  • Shadows have dissapear, even in the simplest example (add3dmodel). In the meantime, I open a comment in the PR
  • Creating a different context instead of reusing Mapbox. solved by Three.js team
  • Review the loaders, it's probably they are misaligned with the current version.
  • FBXLoader now depends on fflate. Other decompression libs (JSZip and ZLib) are not used anymore.
  • Issues with the buffer in console. [.WebGL-0000022C33E91040] GL_INVALID_OPERATION: Insufficient buffer size.
  • In logistics.html demo. Uncaught TypeError: Cannot set property target of # which has only a getter
@jscastro76 jscastro76 self-assigned this Jan 14, 2021
@jscastro76 jscastro76 mentioned this issue Jan 21, 2021
Closed
@fsteggink
Copy link

You might want to upgrade to [email protected]. Please see this advisory: https://www.npmjs.com/advisories/1639.

@jscastro76 jscastro76 changed the title Update to Three.js 124 Update to Three.js 125 Mar 3, 2021
@jscastro76
Copy link
Owner Author

You might want to upgrade to [email protected]. Please see this advisory: https://www.npmjs.com/advisories/1639.

Thanks for the warning, @fsteggink ! So far, there are other issues to find a workaround

@jscastro76 jscastro76 changed the title Update to Three.js 125 Update to Three.js 126 Mar 22, 2021
@jscastro76 jscastro76 added this to the v2.2.1. milestone Mar 30, 2021
@jscastro76 jscastro76 changed the title Update to Three.js 126 Update to Three.js 127 Apr 2, 2021
jscastro76 added a commit that referenced this issue Apr 3, 2021
@jscastro76
## 2.2.1
a2fb805 
Minor version by [@jscastro76](https://github.com/jscastro76), some enhancements and bugs.

#### ✨ Enhancements
- #212 Allow to remove an object by name
- #211 Create an object property that changes all the materials by a color
- #169 Update to Three.js v127
  - #214 Full refactor of tb.tube
  - #215 Refactor tb.line
  - #216 Refactor tb.update
  - #217 utils.material should allow THREE.DoubleSide
  - #218 Remove CustomEvent from events
  - #219 Remove .getInverse()
  - #220 Update Loaders
  - #221 Add fflate module

#### 🪲 Bug fixes
- #222 fflate depends on a physical file

#### 📝 Documentation
- Updated [documentation](/docs/Threebox.md) (`obj.color`, `tb.removeByName`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jscastro76 jscastro76

Labels
📑 code improvement 🔗 external dependencies 🔍 needs investigation
Projects
None yet
Milestone
v2.2.1.
Development

No branches or pull requests
2 participants
@fsteggink @jscastro76