[Cases] Update configure cases breadcrumb to settings (elastic#169532)

## Summary fixes elastic#169213 This PR updates route and deeplink breadcrumb from `Configure cases ` to `Settings`. It also updates bread crumb text for serverless as mentioned in elastic#169401 (review) ![image](https://github.com/elastic/kibana/assets/117571355/94b8a0b8-9842-4570-a2e0-fd7c9b42bcb4) ![image](https://github.com/elastic/kibana/assets/117571355/65666e53-1b61-4088-bf65-87fef6dd70bd) ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
js-jankisalvi · Oct 24, 2023 · 68b2e4d · 68b2e4d
1 parent ad932ec
commit 68b2e4d
Show file tree

Hide file tree

Showing 14 changed files with 46 additions and 30 deletions.
diff --git a/x-pack/plugins/cases/public/common/navigation/deep_links.test.ts b/x-pack/plugins/cases/public/common/navigation/deep_links.test.ts
@@ -19,12 +19,12 @@ describe('getCasesDeepLinks', () => {
         {
           id: 'cases_create',
           path: '/cases/create',
-          title: 'Create New Case',
+          title: 'Create',
         },
         {
           id: 'cases_configure',
           path: '/cases/configure',
-          title: 'Configure Cases',
+          title: 'Settings',
         },
       ],
     });
@@ -40,12 +40,12 @@ describe('getCasesDeepLinks', () => {
         {
           id: 'cases_create',
           path: '/test/create',
-          title: 'Create New Case',
+          title: 'Create',
         },
         {
           id: 'cases_configure',
           path: '/test/configure',
-          title: 'Configure Cases',
+          title: 'Settings',
         },
       ],
     });
@@ -75,13 +75,13 @@ describe('getCasesDeepLinks', () => {
         {
           id: 'cases_create',
           path: '/cases/create',
-          title: 'Create New Case',
+          title: 'Create',
           navLinkStatus: AppNavLinkStatus.hidden,
         },
         {
           id: 'cases_configure',
           path: '/cases/configure',
-          title: 'Configure Cases',
+          title: 'Settings',
           order: 8002,
         },
       ],
@@ -115,12 +115,12 @@ describe('getCasesDeepLinks', () => {
         {
           id: 'cases_create',
           path: '/cases/create',
-          title: 'Create New Case',
+          title: 'Create',
         },
         {
           id: 'cases_configure',
           path: '/cases/configure',
-          title: 'Configure Cases',
+          title: 'Settings',
         },
       ],
     });
@@ -136,7 +136,7 @@ describe('getCasesDeepLinks', () => {
           title: 'My new create cases title',
         },
         cases_configure: {
-          title: 'My new configure cases title',
+          title: 'My new settings title',
         },
       },
     });
@@ -154,7 +154,7 @@ describe('getCasesDeepLinks', () => {
         {
           id: 'cases_configure',
           path: '/cases/configure',
-          title: 'My new configure cases title',
+          title: 'My new settings title',
         },
       ],
     });

diff --git a/x-pack/plugins/cases/public/common/navigation/deep_links.ts b/x-pack/plugins/cases/public/common/navigation/deep_links.ts
@@ -33,15 +33,15 @@ export const getCasesDeepLinks = <T extends AppDeepLink = AppDeepLink>({
   deepLinks: [
     {
       title: i18n.translate('xpack.cases.navigation.create', {
-        defaultMessage: 'Create New Case',
+        defaultMessage: 'Create',
       }),
       ...(extend[CasesDeepLinkId.casesCreate] ?? {}),
       id: CasesDeepLinkId.casesCreate,
       path: getCreateCasePath(basePath),
     },
     {
-      title: i18n.translate('xpack.cases.navigation.configure', {
-        defaultMessage: 'Configure Cases',
+      title: i18n.translate('xpack.cases.navigation.settings', {
+        defaultMessage: 'Settings',
       }),
       ...(extend[CasesDeepLinkId.casesConfigure] ?? {}),
       id: CasesDeepLinkId.casesConfigure,

diff --git a/x-pack/plugins/cases/public/components/app/routes.test.tsx b/x-pack/plugins/cases/public/components/app/routes.test.tsx
@@ -28,7 +28,7 @@ jest.mock('../create', () => ({
 }));
 
 jest.mock('../configure_cases', () => ({
-  ConfigureCases: () => <div>{'Configure cases'}</div>,
+  ConfigureCases: () => <div>{'Settings'}</div>,
 }));
 
 const getCaseViewPaths = () => ['/cases/test-id', '/cases/test-id/comment-id'];
@@ -99,7 +99,7 @@ describe('Cases routes', () => {
   describe('Configure cases', () => {
     it('navigates to the configure cases page', () => {
       renderWithRouter(['/cases/configure']);
-      expect(screen.getByText('Configure cases')).toBeInTheDocument();
+      expect(screen.getByText('Settings')).toBeInTheDocument();
     });
 
     it('shows the no privileges page if the user does not have update privileges', () => {

diff --git a/x-pack/plugins/cases/public/components/use_breadcrumbs/index.test.tsx b/x-pack/plugins/cases/public/components/use_breadcrumbs/index.test.tsx
@@ -119,4 +119,27 @@ describe('useCasesBreadcrumbs', () => {
       expect(mockSetServerlessBreadcrumbs).not.toHaveBeenCalled();
     });
   });
+
+  describe('set settings breadcrumbs', () => {
+    it('call setBreadcrumbs with all items', () => {
+      renderHook(() => useCasesBreadcrumbs(CasesDeepLinkId.casesConfigure), { wrapper });
+      expect(mockSetBreadcrumbs).toHaveBeenCalledWith([
+        { href: '/test', onClick: expect.any(Function), text: 'Test' },
+        { href: CasesDeepLinkId.cases, onClick: expect.any(Function), text: 'Cases' },
+        { text: 'Settings' },
+      ]);
+      expect(mockSetServerlessBreadcrumbs).toHaveBeenCalledWith([]);
+    });
+
+    it('should set the cases title', () => {
+      renderHook(() => useCasesBreadcrumbs(CasesDeepLinkId.casesConfigure), { wrapper });
+      expect(mockSetTitle).toHaveBeenCalledWith(['Settings', 'Cases', 'Test']);
+    });
+
+    it('should not set serverless breadcrumbs in ess', () => {
+      mockGetKibanaServices.mockReturnValueOnce({ serverless: undefined });
+      renderHook(() => useCasesBreadcrumbs(CasesDeepLinkId.casesConfigure), { wrapper });
+      expect(mockSetServerlessBreadcrumbs).not.toHaveBeenCalled();
+    });
+  });
 });
diff --git a/x-pack/plugins/cases/public/components/use_breadcrumbs/index.ts b/x-pack/plugins/cases/public/components/use_breadcrumbs/index.ts
@@ -20,8 +20,8 @@ const casesBreadcrumbTitle: Record<ICasesDeepLinkId, string> = {
   [CasesDeepLinkId.casesCreate]: i18n.translate('xpack.cases.breadcrumbs.create_case', {
     defaultMessage: 'Create',
   }),
-  [CasesDeepLinkId.casesConfigure]: i18n.translate('xpack.cases.breadcrumbs.configure_cases', {
-    defaultMessage: 'Configure',
+  [CasesDeepLinkId.casesConfigure]: i18n.translate('xpack.cases.breadcrumbs.settings', {
+    defaultMessage: 'Settings',
   }),
 };
 

diff --git a/x-pack/plugins/cases/public/containers/configure/translations.ts b/x-pack/plugins/cases/public/containers/configure/translations.ts
@@ -10,5 +10,5 @@ import { i18n } from '@kbn/i18n';
 export * from '../translations';
 
 export const SUCCESS_CONFIGURE = i18n.translate('xpack.cases.configure.successSaveToast', {
-  defaultMessage: 'Saved external connection settings',
+  defaultMessage: 'Settings successfully updated',
 });
diff --git a/x-pack/plugins/security_solution/public/cases/links.ts b/x-pack/plugins/security_solution/public/cases/links.ts
@@ -23,7 +23,6 @@ const casesLinks = getCasesDeepLinks<LinkItem>({
     },
     [SecurityPageName.caseConfigure]: {
       capabilities: [`${CASES_FEATURE_ID}.${UPDATE_CASES_CAPABILITY}`],
-      licenseType: 'gold',
       sideNavDisabled: true,
     },
     [SecurityPageName.caseCreate]: {

diff --git a/x-pack/plugins/translations/translations/fr-FR.json b/x-pack/plugins/translations/translations/fr-FR.json
@@ -10495,7 +10495,6 @@
     "xpack.cases.badge.readOnly.text": "Lecture seule",
     "xpack.cases.badge.readOnly.tooltip": "Impossible de créer ou de modifier des cas",
     "xpack.cases.breadcrumbs.all_cases": "Cas",
-    "xpack.cases.breadcrumbs.configure_cases": "Configurer",
     "xpack.cases.breadcrumbs.create_case": "Créer",
     "xpack.cases.callout.appropriateLicense": "licence appropriée",
     "xpack.cases.callout.cloudDeploymentLink": "déploiement sur le cloud",
@@ -10792,7 +10791,6 @@
     "xpack.cases.markdownEditor.preview": "Aperçu",
     "xpack.cases.modal.attachments.noAttachmentsTitle": "Aucune pièce jointe ajoutée au cas",
     "xpack.cases.navigation.cases": "Cas",
-    "xpack.cases.navigation.configure": "Configurer les cas",
     "xpack.cases.navigation.create": "Créer un nouveau cas",
     "xpack.cases.noPrivileges.button": "Retour aux cas",
     "xpack.cases.noPrivileges.title": "Privilèges requis",

diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json
@@ -10510,7 +10510,6 @@
     "xpack.cases.badge.readOnly.text": "読み取り専用",
     "xpack.cases.badge.readOnly.tooltip": "ケースを作成または編集できません",
     "xpack.cases.breadcrumbs.all_cases": "ケース",
-    "xpack.cases.breadcrumbs.configure_cases": "構成",
     "xpack.cases.breadcrumbs.create_case": "作成",
     "xpack.cases.callout.appropriateLicense": "適切なライセンス",
     "xpack.cases.callout.cloudDeploymentLink": "クラウド展開",
@@ -10807,7 +10806,6 @@
     "xpack.cases.markdownEditor.preview": "プレビュー",
     "xpack.cases.modal.attachments.noAttachmentsTitle": "ケースに追加された添付ファイルはありません",
     "xpack.cases.navigation.cases": "ケース",
-    "xpack.cases.navigation.configure": "ケースを構成",
     "xpack.cases.navigation.create": "新規ケースを作成",
     "xpack.cases.noPrivileges.button": "ケースに戻る",
     "xpack.cases.noPrivileges.title": "権限が必要です",

diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json
@@ -10510,7 +10510,6 @@
     "xpack.cases.badge.readOnly.text": "只读",
     "xpack.cases.badge.readOnly.tooltip": "无法创建或编辑案例",
     "xpack.cases.breadcrumbs.all_cases": "案例",
-    "xpack.cases.breadcrumbs.configure_cases": "配置",
     "xpack.cases.breadcrumbs.create_case": "创建",
     "xpack.cases.callout.appropriateLicense": "适当的许可证",
     "xpack.cases.callout.cloudDeploymentLink": "云部署",
@@ -10807,7 +10806,6 @@
     "xpack.cases.markdownEditor.preview": "预览",
     "xpack.cases.modal.attachments.noAttachmentsTitle": "未向该案例添加任何附件",
     "xpack.cases.navigation.cases": "案例",
-    "xpack.cases.navigation.configure": "配置案例",
     "xpack.cases.navigation.create": "创建新案例",
     "xpack.cases.noPrivileges.button": "返回到案例",
     "xpack.cases.noPrivileges.title": "需要权限",

diff --git a/x-pack/test/functional_with_es_ssl/apps/cases/group2/configure.ts b/x-pack/test/functional_with_es_ssl/apps/cases/group2/configure.ts
@@ -37,7 +37,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
       it('change closure option successfully', async () => {
         await cases.common.selectRadioGroupValue('closure-options-radio-group', 'close-by-pushing');
         const toast = await toasts.getToastElement(1);
-        expect(await toast.getVisibleText()).to.be('Saved external connection settings');
+        expect(await toast.getVisibleText()).to.be('Settings successfully updated');
         await toasts.dismissAllToasts();
         await cases.common.assertRadioGroupValue('closure-options-radio-group', 'close-by-pushing');
       });

diff --git a/x-pack/test_serverless/functional/test_suites/observability/cases/configure.ts b/x-pack/test_serverless/functional/test_suites/observability/cases/configure.ts
@@ -53,7 +53,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
       it('change closure option successfully', async () => {
         await cases.common.selectRadioGroupValue('closure-options-radio-group', 'close-by-pushing');
         const toast = await toasts.getToastElement(1);
-        expect(await toast.getVisibleText()).to.be('Saved external connection settings');
+        expect(await toast.getVisibleText()).to.be('Settings successfully updated');
         await toasts.dismissAllToasts();
       });
     });

diff --git a/x-pack/test_serverless/functional/test_suites/observability/navigation.ts b/x-pack/test_serverless/functional/test_suites/observability/navigation.ts
@@ -108,7 +108,7 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
       await svlCommonNavigation.sidenav.expectLinkActive({
         deepLinkId: 'observability-overview:cases',
       });
-      await svlCommonNavigation.breadcrumbs.expectBreadcrumbTexts(['Cases', 'Create New Case']);
+      await svlCommonNavigation.breadcrumbs.expectBreadcrumbTexts(['Cases', 'Create']);
 
       await svlCommonNavigation.sidenav.clickLink({ deepLinkId: 'observability-overview:cases' });
 
@@ -117,7 +117,7 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
       await svlCommonNavigation.sidenav.expectLinkActive({
         deepLinkId: 'observability-overview:cases',
       });
-      await svlCommonNavigation.breadcrumbs.expectBreadcrumbTexts(['Cases', 'Configure Cases']);
+      await svlCommonNavigation.breadcrumbs.expectBreadcrumbTexts(['Cases', 'Settings']);
     });
   });
 }
diff --git a/x-pack/test_serverless/functional/test_suites/security/ftr/cases/configure.ts b/x-pack/test_serverless/functional/test_suites/security/ftr/cases/configure.ts
@@ -52,7 +52,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
       it('change closure option successfully', async () => {
         await cases.common.selectRadioGroupValue('closure-options-radio-group', 'close-by-pushing');
         const toast = await toasts.getToastElement(1);
-        expect(await toast.getVisibleText()).to.be('Saved external connection settings');
+        expect(await toast.getVisibleText()).to.be('Settings successfully updated');
         await toasts.dismissAllToasts();
       });
     });