Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution]Breadcrumb and Global Search incorrect for Cases > Settings Page #169213

Closed
ghost opened this issue Oct 18, 2023 · 3 comments · Fixed by #169532
Closed

[Security Solution]Breadcrumb and Global Search incorrect for Cases > Settings Page #169213

ghost opened this issue Oct 18, 2023 · 3 comments · Fixed by #169532
Assignees
Labels
bug Fixes for quality problems that affect the customer experience estimate:medium Medium Estimated Level of Effort Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. triage_needed v8.11.0

Comments

@ghost
Copy link

ghost commented Oct 18, 2023

Describe the bug:
Breadcrumb and Global Search incorrect for Cases > Settings Page

Kibana/Elasticsearch Stack version
Version: 8.11.0 BC3
Commit: 714189f
Build: 67923

Browser and Browser OS Version:
Firefox for windows OS
Version: 118.0.1

Elastic Endpoint Version:
8.11

Original install method:
None

Functional Area:
Alert Flyout

Initial Setup:

  • Kibana Instance version 8.11.0 BC3 should be available

Steps to reproduce

  • Go to Case Page
  • Observe the Settings button along the create case button
  • Click on Settings button
  • Observer the breadcrumb "Security > Cases > Configure" instead it should be "Security > Cases > Configure"
  • Search Configure Cases in global search bar and you will land to settings page which is also incorrect global deep link text should also update

Additional Observation

  • 8.10.3 Screen-Shoot when naming has not been changed to settings

image

Current behavior

  • Breadcrumb and Global Search incorrect for Connector Configuration

Expected behavior:

  • Breadcrumb and Global Search text information should be correct for Setting Page

Screen-Shot:

image

@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Oct 18, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost ghost added estimate:medium Medium Estimated Level of Effort v8.11.0 labels Oct 18, 2023
@ghost ghost assigned MadameSheema Oct 18, 2023
@cnasikas cnasikas added the Feature:Cases Cases feature label Oct 18, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@MadameSheema MadameSheema removed their assignment Oct 18, 2023
@MadameSheema MadameSheema added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Oct 18, 2023
@cnasikas
Copy link
Member

Thanks for the report @karanbirsingh-qasource! Indeed we changed the name from Configure to Settings. We can work on the issue as we control the breadcrumbs.

@js-jankisalvi js-jankisalvi self-assigned this Oct 23, 2023
js-jankisalvi added a commit that referenced this issue Oct 24, 2023
## Summary

fixes #169213

This PR updates route and deeplink breadcrumb from `Configure cases ` to
`Settings`.

It also updates bread crumb text for serverless as mentioned in
#169401 (review)


![image](https://github.com/elastic/kibana/assets/117571355/94b8a0b8-9842-4570-a2e0-fd7c9b42bcb4)


![image](https://github.com/elastic/kibana/assets/117571355/65666e53-1b61-4088-bf65-87fef6dd70bd)

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
js-jankisalvi added a commit to js-jankisalvi/kibana that referenced this issue Oct 24, 2023
## Summary

fixes elastic#169213

This PR updates route and deeplink breadcrumb from `Configure cases ` to
`Settings`.

It also updates bread crumb text for serverless as mentioned in
elastic#169401 (review)

![image](https://github.com/elastic/kibana/assets/117571355/94b8a0b8-9842-4570-a2e0-fd7c9b42bcb4)

![image](https://github.com/elastic/kibana/assets/117571355/65666e53-1b61-4088-bf65-87fef6dd70bd)

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 68b2e4d)

# Conflicts:
#	x-pack/test_serverless/functional/test_suites/observability/navigation.ts
js-jankisalvi referenced this issue Oct 25, 2023
#169680)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Cases] Update configure cases breadcrumb to settings
(#169532)](#169532)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Janki
Salvi","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-24T16:01:19Z","message":"[Cases]
Update configure cases breadcrumb to settings (#169532)\n\n##
Summary\r\n\r\nfixes
https://github.com/elastic/kibana/issues/169213\r\n\r\nThis PR updates
route and deeplink breadcrumb from `Configure cases `
to\r\n`Settings`.\r\n\r\nIt also updates bread crumb text for serverless
as mentioned
in\r\nhttps://github.com//pull/169401#pullrequestreview-1688154396\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/117571355/94b8a0b8-9842-4570-a2e0-fd7c9b42bcb4)\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/117571355/65666e53-1b61-4088-bf65-87fef6dd70bd)\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n###
For maintainers\r\n\r\n- [x] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"68b2e4d835541cc46231129dfcbb5448eeabc42c","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","Feature:Cases","v8.11.0","v8.12.0"],"number":169532,"url":"https://github.com/elastic/kibana/pull/169532","mergeCommit":{"message":"[Cases]
Update configure cases breadcrumb to settings (#169532)\n\n##
Summary\r\n\r\nfixes
https://github.com/elastic/kibana/issues/169213\r\n\r\nThis PR updates
route and deeplink breadcrumb from `Configure cases `
to\r\n`Settings`.\r\n\r\nIt also updates bread crumb text for serverless
as mentioned
in\r\nhttps://github.com//pull/169401#pullrequestreview-1688154396\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/117571355/94b8a0b8-9842-4570-a2e0-fd7c9b42bcb4)\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/117571355/65666e53-1b61-4088-bf65-87fef6dd70bd)\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n###
For maintainers\r\n\r\n- [x] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"68b2e4d835541cc46231129dfcbb5448eeabc42c"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169532","number":169532,"mergeCommit":{"message":"[Cases]
Update configure cases breadcrumb to settings (#169532)\n\n##
Summary\r\n\r\nfixes
https://github.com/elastic/kibana/issues/169213\r\n\r\nThis PR updates
route and deeplink breadcrumb from `Configure cases `
to\r\n`Settings`.\r\n\r\nIt also updates bread crumb text for serverless
as mentioned
in\r\nhttps://github.com//pull/169401#pullrequestreview-1688154396\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/117571355/94b8a0b8-9842-4570-a2e0-fd7c9b42bcb4)\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/117571355/65666e53-1b61-4088-bf65-87fef6dd70bd)\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n###
For maintainers\r\n\r\n- [x] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"68b2e4d835541cc46231129dfcbb5448eeabc42c"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience estimate:medium Medium Estimated Level of Effort Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. triage_needed v8.11.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants