Merge Master back into fork #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Writing flow: Copy whole block if no text is selected * Append change to package changelog * Consider full selection when not copying/cutting * Copy notice: Reveal block type if only one block copied * Flash block outline in response to copy action * Notify of copy and cut actions w/ useNotifyCopy hook * Reduce block highlight time. * Block Editor: Add action `flashBlock` * E2E: Test whole-block copy, cut and paste Co-authored-by: Matías Ventura <[email protected]>
This allows videos to generally autoplay on mobile devices. It registers a server callback for dealing with existing background videos and the lack of kses support for the attribute.
* Remove insert block delay from e2e tests * useLayoutEffect instead of useEffect
* Mark RovingTabIndex as unstable * Add experimental disclaimer to TreeGrid docs * Update manifest * Make RovingTabIndex an internal part of TreeGrid and remove any exports * Fix failing test
This allows tslib for #21024
* Block Directory: Add error messages inline. * Make the linter happy * Place the retry button on its own line. * Update classNames to match standards * Get the error notices in `DownloadableBlockNotice` This prevents some prop-drilling by getting the notices when we need them * Get `isLoading` in `DownloadableBlockHeader` This prevents some prop-drilling by getting the loading status when we need it * Avoid `children` abstraction in item * Refactor install callback This consolidates the install logic into one callback function, simplifying the list component * Disable the "Add Block" button when installing * Fix broken tests. * Update padding under error messages. Co-authored-by: Kelly Dwan <[email protected]>
* Use hasFinishedResolution to correctly determine loading state * First draft of a form to create a new menu * Add conditional logic for UI * Use saveMenu action to create menu * Handle returning to initial state when deleting last menu * Add create first menu message * Markup CreateMenuForm component as a proper form * Add button for creating new menus when an existing menu is selected * Improve responsive styles * Fix header text displaying at wrong time * Add an option for cancelling the menu creation process * Tidy up styling of cancel button * Tidy up rendering logic * Use notices for errors * Add busy indicator that is not really shown * Use getIsResolving for more succinct code * Focus input field when creating a menu * Try withFocusReturn * Fix returning to first menu when selecting cancel * Try a snackbar * Remove dead code * Remove unused logic for hiding contents of panels * Show create panel at same time as other panels * Try setting the created menu after menu creation * Try only showing loading spinner on first load * Fix menu creation notifications * Only hide panels on first load * Fix uncontrolled select * Fix button busy appearance * Use pixel value for margin * Ensure items do not take up full width * Ensure loading indicator when creating menus isn't shown when validation fails. Co-authored-by: Adam Zielinski <[email protected]> * Use a `finally` clause to mark when a save finishes Co-authored-by: Adam Zielinski <[email protected]> * Fix menu save error message * Remove selector dependency * Center items along horizontal axis when using row layout Co-authored-by: Adam Zielinski <[email protected]>
* Scripts: Add official flags for build and start scripts * Add link to this PR in the CHANGELOG file * Update README.md * Update CHANGELOG.md * Update webpack.config.js
* Wrap showAvatar check in empty() call * Still render the block when no attributes are set
* Make block inspector items editable * Improve the performance * Introduce <BlockNavigationEditor /> component * Remove the wp-block-navigation-link__label class name from RichText * remove the dependency list optimization
Merging as this has a design and code review passed.
Updates the note for the blocks.getSaveContent.extraProps to clarify that using the filter can cause invalidation and direct developers to use render_block server-side instead. Fixes: #22386
* Update step values for spacer and cover blocks. * Remove step values from spacer and cover blocks
* Add test. * Remove protocol.
* Block Editor: Add BlockContext component to type-checking * Include element package in references
* Removed border-radius from SVGs * Update SVGs to match new size * Update image height and styles * Move images above heading * Layout and spacing updates * Reduce size of page control dots * Remove forward/back icons * Update paragraph margin * Remove commented code * More layout updates and remove commented code * Set forward button in bold * Remove commented code * Add 9e6d4e8 * Aligment and spacing of page control dots * Update heading font-size and spacing * Update footer's padding * Update text's margins * Add top margin to pagination controls * Remove unecessary "mobile" styles * Update modal's placement on mobile sizes * Place footer at bottom of modal on small viewports * Update mobile styles for Finish button * Remove little triangle corner from block illustration * Add more space between pagination dots and heading * Fix text line height discrepancies when inserter icon is in-line * Add hover state for prev/next links * Update hover style of close button * Normalize modal's height to avoid jump between steps * Change background color on illustrations * Add reduced motion query to show/hide gifs * Add data URI for CanvasImage gif * Add data URI for EditorImage gif * Add data URI for BlockLibraryImage gif * Add data URI for DocumentationImage gif * Update class names * Update bg color of image to match illustrations * Update packages/components/src/guide/README.md Co-authored-by: Robert Anderson <[email protected]> Co-authored-by: Robert Anderson <[email protected]>
On the web this checking the active formats makes sense because you
have a mode where you are inside a selection ("active selection").
That doesn't happen on mobile so having a selection active shouldn't
block the deletion and merge.
* Buttons: allow split and merge * Don't add empty block on paste * Update packages/block-editor/src/components/rich-text/index.js Co-authored-by: Miguel Fonseca <[email protected]> * Keep all attrs on split * Keep attrs on merge * Adjust paste e2e tests Co-authored-by: Miguel Fonseca <[email protected]>
* Block Edit: use hooks * Clean up
* New hook: useCopyOnClick * Add docs * Add comment * Fix case where hook is called but no reference is defined * fix e2e * package lock * Fix package
* Group block: match front end in editor * Fix selectors * wip
I wish to become a code maintainer of the PHP on the gutenberg plugin.
* Change placeholder text color * Use $dark-gray-400 instead
…22422) * Block Library: Move supports to block.json * Blocks: Add "features" alias for "supports" field * Block Library: Move "supports" to block.json files * Remove server-register.json generator in favor of reading block.json files * Remove temporary TODO code comments * Improve registration on the server for the Post Comments block * Move supports to block.json for Widget Area block * Fix rebase issue for Query blocks
* Improve UnitControl component This update adds rich features and interactions to the UnitControl component. Originally, this work was in support of adding padding controls to the Cover block. This update abstracts just the UnitControls from that effort. UnitControl and NumberControl are now powered by a new lower level primitive: InputControl. InputControl handles the majority of the interaction and event logic. Components using it, like NumberControl, are able to tap into the state flow and add features like "drag to update". * Update docs manifest * Fix inputControl action type for ~SUBMIT~ COMMIT * Remove stateReducer memoization. Add isPressEnterToChange knob for Input stories * Refactors parseUnit utility * Fixed unit parsing in parseUnit utility function * Remove typos in README description * Fix color values and offsets for InputControl label * Remove arg flattening and rename combineStateReducers to composeStateReducers * Update packages/components/src/unit-control/utils.js Co-authored-by: Zebulan Stanphill <[email protected]> * Add default value for isFocused in InputControl Backdrop * Improve label rendering for long values with floating label Also improve Safari placeholder vertical alignment * Remove unused composeStateReducers from useInputControlStateReducer * Replace combinedStateReducers in args + comments with composedStateReducers * Update return state of composeStateReducers * Optimize parseUnit with keyBy rather than Array.find * Refactor classNames for InputControl and UnitControl * Revert "Optimize parseUnit with keyBy rather than Array.find" This reverts commit 8fdc6e8. Co-authored-by: Zebulan Stanphill <[email protected]>
* Update blocks-view selector in e2e-test-util * E2E Test Utils: Use predictable selectors for inserter tab buttons Co-authored-by: Andrew Duthie <[email protected]>
Destroys the downloaded files and created containers.
…2286) * Skip to activation if the block is installed. * Add a comment to represent intention. * Remove mistake tab in comment. * Fix php linting errors.
* moved subcomponents to their own files * move save button * update text prompt * added isReviewing state * changed prompt text * fixed multi-entity-editing tests * updated multi-entity-saving test * remove useCallback * add labels to getDirtyEntitiyRecords * remove unnecessary select to get label * generate prompt phrase based on what has been edited * reverted selector change * dang auto-ppretty * check name match is found before calling function * fixed other test dependent on seeing checkboxes
* Update e2e tests to use wp-env when run in travis * Use wp command * Use quotes around command to pass to docker container * Set script debug to false * Try chmod on the uploads folder * Adding missing . * Remove duplicate wp-env start commands * Ensure PHP binary is defined
This PR advances the use of experimental-theme.json by themes. This adds: - the ability to add presets (color, font-size, gradients) via the theme.json file - the presets declared by the theme (via this file or via functions.php) are now output as CSS Custom Properties available for themes to use - declare a set of "managed CSS" for some blocks, to match what a user can do in the editor
* Super early prototype * Hide <BlockSettingsMenu /> in the top level item * Hide the ellipsis menu behind __experimentalWithEllipsisMenu flag * Move the menu to the same level as mover cells * Use a vertical icon for the ellipsis menu * Support for arbitrary clientIds in BlockSettingsMenuControlsSlot * Use a smaller dropdown button in the block navigator * Add the ellipsis menu to the post editor block navigation * Reduce the size of movers * Update packages/edit-navigation/src/components/menu-editor/navigation-structure-panel.js Co-authored-by: Robert Anderson <[email protected]> * Remove unnecessary arg to useBlockNavigator * Pass props to nested BlockSettingsDropdown Co-authored-by: Robert Anderson <[email protected]>
* Alternate approach, initial work. * Visual refinements. * Code cleanup. * Address feedback and polish. * Semi-transparent header.
* Fix CSS bleed in button component. * Duplicate CSS bleed code in edit-site.
* Add side effect documentation * Split side effects docs into their own file * Small wording fix * Fix indentation for last example
* Fix prop spreading * Turn the select button and the slot into two distinct components that do not reuse a shared wrapper * Update classnames * Add onClick prop for fallback if no fills are defined * Divide components up into separate files * Fix incorrect classnames * Fix import * Fix exports * Make export consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How has this been tested?
Screenshots
Types of changes
Checklist: