-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CSS bleed in button component. #22460
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Feature] Custom Editor Styles
Functionality for adding custom editor styles
[Type] Enhancement
A suggestion for improvement.
labels
May 19, 2020
jasmussen
force-pushed
the
try/button-font-size-bleed
branch
from
May 19, 2020 10:35
c4b3d9a
to
70a56ce
Compare
Size Change: +10.5 kB (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
I'm fine with this fix but it only works on edit-post (not on edit-widgets, not on edit-site). |
Is there a better place than visual editor to put this, you think? |
I don't know, we could just duplicate the code in edit-site for now (as edit-widgets don't use editor styles) and comment on why it's needed. |
youknowriad
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Custom Editor Styles
Functionality for adding custom editor styles
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #22263. This fixes a CSS bleed issue for the button component when used inside the editing canvas.
When an editor style is added, which restyles the
button
element, it bleeds into the button component. This addresses that.Example CSS:
#22263 took a slightly more dangerous approach that might cause issues, but this approach should be rather safe, as it's adding to an existing rule that fixes the same issue but for fonts.
Before:
After: