Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gzip issue with jruby and Rack::ETag #1371

Closed
jillesvangurp opened this issue Dec 30, 2013 · 2 comments
Closed

gzip issue with jruby and Rack::ETag #1371

jillesvangurp opened this issue Dec 30, 2013 · 2 comments
Milestone

Comments

@jillesvangurp
Copy link

A few months ago I reported this issue against rack:

rack/rack#571 (gzip issue with jruby and Rack::ETag)

It seems the problem may be with the way jruby is implementing gzip compression, which apparently is is doing some strange reuse of objects internally.

The bug report above includes a test case to reproduce and some analysis by @srawlins

In short the problem appears to be that rack's etag handler is concatenating parts that are rightfully assumed to be immutable but that are actually being modified in jruby's gzip implementation. Since this seems to be a jruby bug, the issue was closed a few days on the rack side.

@bigsur0
Copy link
Contributor

bigsur0 commented Oct 2, 2015

We just hit this bug too, is there a fix?

@enebo enebo added this to the JRuby 1.7.23 milestone Feb 17, 2017
@enebo
Copy link
Member

enebo commented Feb 17, 2017

Fixed by PR #3421.

@enebo enebo closed this as completed Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants