Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Compression #2056

Closed
sschepens opened this issue Nov 28, 2014 · 5 comments
Closed

Request Compression #2056

sschepens opened this issue Nov 28, 2014 · 5 comments

Comments

@sschepens
Copy link

Kibana 4 does not seem to support gzip/deflate compression.
XHR requests by default send accept-encoding gzip, deflate and configuring elasticsearch to use http compression makes kibana3 use http compression hassle-free.
It seems kibana4 is not requesting compressed content or the new server proxying requests is not supporting compression., it shouldn't be too much trouble to implement this, and makes requests so much faster, considering json is extremely compressible and elasticsearch tends to return A LOT of information.

Maybe it's just as simple as using Rack::Deflate

@rashidkpc
Copy link
Contributor

An excellent point, would be nice to get this in there sooner than later.

@sschepens
Copy link
Author

Great to see this already in! Are we sure rack reverse proxy does not clean Encoding related headers, just to be sure if this is working both sides, it's mostly a win to compress on kibana side because it's what ends up going to the end user, but compressing both sides could improve performance a little bit.

EDIT: just read the PR description, i don't know how rack reverse proxy works, but a reverse proxy should just copy what it received to the other end, without decompressing or parsing anything, shouldn't it?

cc @simianhacker

@lukasolson lukasolson removed the help wanted adoptme label Dec 2, 2014
rashidkpc added a commit that referenced this issue Dec 3, 2014
Closes #2056 - Added Rack::Deflater middleware
@simianhacker
Copy link
Member

Reopening because we had to revert code because of #2199

@sschepens
Copy link
Author

@simianhacker Is there a reason why it doesnt work in JRuby? I don't see any issue in rack's repository pointing that it doesn't work on JRuby

@simianhacker
Copy link
Member

Rack::Deflater only works with the MRI version of Ruby. Found this in the JRuby issues: jruby/jruby#1371

This issue is now closed with the new version of the server implemented in Node.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants