Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate jQuery.fx.interval as of 3.0 #969

Closed
wants to merge 1 commit into from
Closed

Deprecate jQuery.fx.interval as of 3.0 #969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions entries/jQuery.fx.interval.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
<?xml version="1.0"?>
<entry type="property" name="jQuery.fx.interval" return="Number">
<entry type="property" name="jQuery.fx.interval" return="Number" deprecated="3.0">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not deprecated in 3.0 but will be in 3.2. If there's a category missing, it should be added.

Do we need to look into things currently tagged as deprecated="3.0"? May there be more things to correct there?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything marked deprecated-3.0? It looks like all the deprecations from the upgrade guide are missing.

It might be good to make this particular one effective with 3.0 since we started using rAF then. For the others I agree, 3.2 would be better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I guess this makes sense to target 3.0 then, our Core ticket still mentions 3.2.0, though, IIRC.

I'll see what's up with other deprecations.

<title>jQuery.fx.interval</title>
<desc>The rate (in milliseconds) at which animations fire.</desc>
<signature>
<added>1.4.3</added>
</signature>
<longdesc>
<p>This property can be manipulated to adjust the number of frames per second at which animations will run. The default is 13 milliseconds. Making this a lower number could make the animations run smoother in faster browsers (such as Chrome) but there may be performance and CPU implications of doing so.</p>
<p>This property is deprecated as of version 3.0, and has no effect in browsers that support the <a href="http://caniuse.com/#feat=requestanimationframe"><code>requestAnimationFrame</code></a> method.</p>
<p>On browsers that do not support <code>requestAnimationFrame</code>, this property can be changed to adjust the interval at which animations will run. The default is 13 milliseconds.</p>
<p>Since jQuery uses one global interval, no animation should be running or all animations should stop for the change of this property to take effect.</p>
</longdesc>
<example>
Expand Down Expand Up @@ -34,4 +35,5 @@ $( "input" ).click(function() {
<category slug="effects/custom-effects"/>
<category slug="properties/global-jquery-object-properties"/>
<category slug="version/1.4.3"/>
<category slug="deprecated/deprecated-3.0"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, deprecated/deprecated-3.2.

</entry>