Deprecate jQuery.fx.interval as of 3.0 #969
Conversation
|
LGTM |
| @@ -1,12 +1,13 @@ | |||
| <?xml version="1.0"?> | |||
| <entry type="property" name="jQuery.fx.interval" return="Number"> | |||
| <entry type="property" name="jQuery.fx.interval" return="Number" deprecated="3.0"> | |||
There was a problem hiding this comment.
It's not deprecated in 3.0 but will be in 3.2. If there's a category missing, it should be added.
Do we need to look into things currently tagged as deprecated="3.0"? May there be more things to correct there?
There was a problem hiding this comment.
Is there anything marked deprecated-3.0? It looks like all the deprecations from the upgrade guide are missing.
It might be good to make this particular one effective with 3.0 since we started using rAF then. For the others I agree, 3.2 would be better.
There was a problem hiding this comment.
I see. I guess this makes sense to target 3.0 then, our Core ticket still mentions 3.2.0, though, IIRC.
I'll see what's up with other deprecations.
|
This failed the build. The 3.0 deprecation category doesn't exist yet. One of the currently open pull requests creates this category, though. ( #948) |
|
@Krinkle Thanks for the update. I pinged Aurelio & a couple of teams, I'll try to get this landed soon. |
|
Ack! Sorry, my fault, I am running on Windows and have never been able to get things running properly on a local build. Can someone who has a working local setup try #948 and then land it? |
|
The site deployment infrastructure was broken for several weeks so even the commit before this one wasn't deployed yet. I've manually triggered a build for e55cf63 (1.12.11) just now, so that this no longer blocks other changes waiting for deployment. (https://github.com/jquery/infrastructure/issues/404) |
|
I landed #948, deployment now works fine for the Core API site. |
|
🎆 👯 🎆 |
Ref jquery/jquery#3154