Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to standard v12 #685

Merged
merged 1 commit into from
May 14, 2019
Merged

Upgrade to standard v12 #685

merged 1 commit into from
May 14, 2019

Conversation

RyanZim
Copy link
Collaborator

@RyanZim RyanZim commented May 14, 2019

Closes #636

@RyanZim RyanZim requested review from JPeer264 and manidlou May 14, 2019 17:22
JPeer264
JPeer264 approved these changes May 14, 2019
View reviewed changes
Copy link
Collaborator

@JPeer264 JPeer264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.835% when pulling fbaa986 on upgrade-standard into fa661f3 on master.

@RyanZim RyanZim merged commit f3a2eed into master May 14, 2019
@RyanZim RyanZim deleted the upgrade-standard branch May 14, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPeer264 JPeer264 JPeer264 approved these changes

@manidlou manidlou Awaiting requested review from manidlou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RyanZim @coveralls @JPeer264