Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update standard libraries and update code accordingly #636

Closed

Conversation

mbargiel
Copy link

This PR updates the standard and standard-markdown and updates the code and docs accordingly (in the example code snippets).

Two types of changes were made:

  • Spaces inside { and } (e.g. { key: value } rather than {key: value}
  • Extra Indentation when chaining promises over multiple lines (in example code only)

This is a fix for #631.

@mbargiel
Copy link
Author

Note: this PR should be merged before #633 (because 633 will need a minor update due to the spacing rule changes in the latest standard rules)

@mbargiel
Copy link
Author

mbargiel commented Oct 17, 2018

Oh hey, my PR is almost an exact copy of #624, except:

  • this PR is a single commit
  • this PR also fixed a typo in a comment
  • this PR fixed assert.equals with assert.strictEquals rather than assert.strict.equals
  • this PR bumps standard-markdown to ^5.0.1 rather than ^5.0.0

@RyanZim
Copy link
Collaborator

RyanZim commented Nov 7, 2018

Will need rebased after v8 is merged, see #648 for more details.

@RyanZim RyanZim mentioned this pull request May 14, 2019
@RyanZim RyanZim closed this in #685 May 14, 2019
@mbargiel mbargiel deleted the fix/update-standard-markdown branch May 14, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants