Copy clobber flag never err even when true

[ryancmlee]

In the following code err is never not null:

fs.copy(sourcePath, targetPath, { clobber: true  }, (err) =>
{
    if (err)
        debugger
    fs.copy(sourcePath, targetPath, { clobber: true}, (err) =>
    {
        if (err)
            debugger
        fs.copy(sourcePath, targetPath, { clobber: false}, (err) =>
        {
            if (err)
                debugger
            fs.copy(sourcePath, targetPath, { clobber: false }, (err) =>
            {
                if (err)
                    debugger
            })
        })
    })
})

Maybe this is intended but then at least add the option for open flags so I can at least put wx and have it err.code = "EEXIST"

Thanks,
Ryan

[qqilihq]

I'm asking myself as well:

Is there any way at all to determine, if the file content was copied, when clobber is set to false?

[RyanZim]

@ryancmlee @qqilihq Good points. @jprichardson Thoughts?

[jprichardson]

Yep, this is a bug. If clobber is false and the destination exists, there should be an Error.

[RyanZim]

OK, will investigate.

[RyanZim]

The issue is https://github.com/jprichardson/node-fs-extra/blob/master/lib/copy/ncp.js#L92. @jprichardson Should I attempt to create a fake EEXIST error here or what?

[jprichardson]

@RyanZim yep, I think that'd be fine.

[RyanZim]

@jprichardson Creating a fake SystemError isn't easy, and I don't think I can replicate it completely. Advice?

[jprichardson]

@RyanZim what about...

const err = new Error(file + ' already exists.')
err.code = EEXIST

?

[RyanZim]

I guess that will cover most cases; still will have a JS stack trace, IDK.

Should also set err.errno = -17 & err.path = file.