please make sure the first argument in callback is error object

[dead-horse]

https://github.com/jprichardson/node-fs-extra/blob/master/lib/copy/ncp.js#L237

[jprichardson]

You're right, this should be fixed and be Error? (Error or null/undefined).

[RyanZim]

@jprichardson Can you elaborate a bit?

[jprichardson]

@RyanZim copy() sometimes returns an array of errors instead of an Error object. This should be fixed for 1.0.0. The problem is... what should the behavior be like? First error? First error with an array of the other errors?

[RyanZim]

@jprichardson Let's face it: ncp.js need rewritten. The resulting rewrite would probably make it small enough to inline in https://github.com/jprichardson/node-fs-extra/blob/master/lib/copy/copy.js. I initially thought that perhaps we could keep it running long enough to survive the v1.0.0 release, but I'm not sure.

First error?

👍

Should all the issues pertaining to ncp.js be consolidated into one issue tracking the rewrite?

[jprichardson]

Should all the issues pertaining to ncp.js be consolidated into one issue tracking the rewrite?

I'm fine with this. It's changed significantly since the original ncp and has many bugs fixed. My major concern with the rewrite is that it delays the release of 1.0.0. May be best to do it for 2.0.0. But if you feel differently, than I'm more than fine with it for 1.0.0.

[RyanZim]

@jprichardson Not set on it, but I'm afraid fixing all the bugs in ncp is going to take longer than rewriting it. 😀