Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken edge click on cluster chart #1595

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Feb 21, 2024

Currently clicking the edges in the cluster graph does not redirect to the comparison.
The issue is because the params of the ComparisonView were changed in #1176 to support opening things in new tabs. This change was not addapted in the cluster graph

@Kr0nox Kr0nox added bug Issue/PR that involves a bug report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Feb 21, 2024
@Kr0nox Kr0nox requested review from tsaglam and sebinside February 21, 2024 15:27
Copy link

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tsaglam tsaglam merged commit c7edd4c into develop Feb 22, 2024
16 checks passed
@tsaglam tsaglam deleted the bug-fix/cluster-edge-click branch February 22, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR that involves a bug report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants