-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal Report Viewer: host and use the the report viewer locally #1176
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
…eb-viewer # Conflicts: # pom.xml
… is not used for something else.
…o feature/internal-web-viewer # Conflicts: # cli/src/main/java/de/jplag/cli/server/ReportViewer.java # report-viewer/package-lock.json
…o feature/internal-web-viewer
Should be ready to merge after #1370 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments . Probably, Docs are missing
core/src/main/java/de/jplag/reporting/reportobject/ReportObjectFactory.java
Outdated
Show resolved
Hide resolved
@Kr0nox Could you please merge the develop branch into this branch? There are some conflicts in .vue files. Or should I just always accept the version from develop? |
…eb-viewer # Conflicts: # .github/workflows/maven.yml # .github/workflows/publish.yml # .github/workflows/sonarcloud-branch.yml # .github/workflows/sonarcloud-pr.yml # .github/workflows/spotless.yml # pom.xml # report-viewer/src/components/ComparisonsTable.vue # report-viewer/src/viewWrapper/ComparisonViewWrapper.vue # report-viewer/src/views/FileUploadView.vue
@TwoOfTwelve it is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides my two small comments (please see above), I'm fine with this PR, works great! We should merge this as soon as possible to have more than 0 days of integration testing before the 5.0 release.
Sorry, I missed the sonarcloud issues. The remaining issues cannot be fixed as far as I can see. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor issues below. The bigger issue is: When I package the jar and either use VIEW or RUN_AND_VIEW I end up with:
2024-02-20-12:05:59_748 [INFO] CLI - ReportViewer started on port http://localhost:1996
2024-02-20 12:05:59.899 java[52709:33325826] WARNING: Secure coding is automatically enabled for restorable state! However, not on all supported macOS versions of this application. Opt-in to secure coding explicitly by implementing NSApplicationDelegate.applicationSupportsSecureRestorableState:.
Press Enter key to exit...
In the browser, I cannot load the page ("The connection to the server was reset while the page was loading".).
…eb-viewer # Conflicts: # cli/src/main/java/de/jplag/cli/CLI.java
Quality Gate passed for 'JPlag Report Viewer'Issues Measures |
Quality Gate passed for 'JPlag Plagiarism Detector'Issues Measures |
Did you make sure you compiled JPlag with -P with-report-viewer? Otherwise the report-viewer will not be bundled and exactly this error will occur. Also I think sometimes maven does not build the report-viewer for some reason, so you could try to build it manually beforehand. |
Thanks, now it works! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Local mode works when built as a jar. Both view only as well as run and view. What is currently not adapted is the readme (especially regarding build commands), but I will do this separately.
This PR re-integrates a ReportViewer into JPlag. It allows users to launch the web-based report viewer locally by self-hosting it automatically. This feature is currently not mandatory, meaning users can choose to use it via the CLI parameter
--mode
. This parameter supports only running, running + viewing, as well as only viewing. In the future, this local model will become the default.This PR thus also contributes to #1190.