Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleted Metric record #1415

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Deleted Metric record #1415

merged 2 commits into from
Dec 7, 2023

Conversation

TwoOfTwelve
Copy link
Contributor

Deleted the Metric record, as it was not used anymore. #717 can be closed with this PR.

@Kr0nox
Copy link
Member

Kr0nox commented Dec 5, 2023

The issue also mentions moving the messages class

After this refactoring, we should move the Messages class and all its resources to the CLI package and change the visibility to protected.

Does this still apply?

@TwoOfTwelve
Copy link
Contributor Author

That class was also unused. I deleted it too.

@TwoOfTwelve TwoOfTwelve requested a review from tsaglam December 5, 2023 09:49
@tsaglam tsaglam added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change labels Dec 5, 2023
@tsaglam tsaglam merged commit 8a32eb4 into develop Dec 7, 2023
8 checks passed
@tsaglam tsaglam deleted the feature/deleteMetricRecord branch December 7, 2023 09:38
@tsaglam tsaglam mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kr0nox Kr0nox Kr0nox approved these changes

@tsaglam tsaglam tsaglam approved these changes

Assignees
No one assigned
Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TwoOfTwelve @Kr0nox @tsaglam