Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metric data object stores UI description #717

Closed
JanWittler opened this issue Sep 30, 2022 · 1 comment
Closed

Metric data object stores UI description #717

JanWittler opened this issue Sep 30, 2022 · 1 comment
Assignees
@TwoOfTwelve
Labels
enhancement Issue/PR that involves features, improvements and other changes good first issue Good first issue for new contributors. New contributors are welcome! minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies

Comments

@JanWittler
Copy link
Contributor

The Metric record stores the description that should be shown in the report viewer. This breaks the intended separation between data and UI. As such, we should refactor Metric to only contain an identifier of the type of metric (e.g. modeled as an enum) and load the according description in the report viewer based on that identifier.

After this refactoring, we should move the Messages class and all its resources to the CLI package and change the visibility to protected.
@JanWittler JanWittler added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change good first issue Good first issue for new contributors. New contributors are welcome! labels Sep 30, 2022
@tsaglam tsaglam added the report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies label Feb 9, 2023
@TwoOfTwelve TwoOfTwelve self-assigned this Nov 28, 2023
@TwoOfTwelve TwoOfTwelve mentioned this issue Dec 5, 2023
Merged
@tsaglam
Copy link
Member

tsaglam commented May 3, 2024

Closed by #1415.

@tsaglam tsaglam closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TwoOfTwelve TwoOfTwelve

Labels
enhancement Issue/PR that involves features, improvements and other changes good first issue Good first issue for new contributors. New contributors are welcome! minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tsaglam @JanWittler @TwoOfTwelve