Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/search bar flint #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enhancement/search bar flint #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bfeb19
add context
mengweieric Feb 21, 2024
68e0c94
wrap app with context provider
mengweieric Feb 21, 2024
c3c29da
decouple explorer from app analytics and add new search bar component
mengweieric Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions public/components/application_analytics/components/application.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,25 +25,22 @@
import React, { ReactChild, useEffect, useState } from 'react';
import { useHistory } from 'react-router-dom';
import { useDispatch } from 'react-redux';
import { last } from 'lodash';
import { VisualizationType } from 'common/types/custom_panels';
import { TracesContent } from '../../../components/trace_analytics/components/traces/traces_content';
import { DashboardContent } from '../../../components/trace_analytics/components/dashboard/dashboard_content';
import { ServicesContent } from '../../trace_analytics/components/services/services_content';
import {
filtersToDsl,
PanelTitle,
} from '../../../../public/components/trace_analytics/components/common/helper_functions';
import { SpanDetailTable } from '../../../../public/components/trace_analytics/components/traces/span_detail_table';
import { Explorer } from '../../event_analytics/explorer/explorer';
import { LegacyExplorer } from '../../event_analytics/explorer/legacy_explorer';
import { Configuration } from './configuration';
import {
TAB_CONFIG_ID,
TAB_CONFIG_TITLE,
TAB_LOG_ID,
TAB_LOG_TITLE,
TAB_OVERVIEW_ID,
TAB_OVERVIEW_TITLE,
TAB_PANEL_ID,
TAB_PANEL_TITLE,
TAB_SERVICE_ID,
Expand All @@ -66,7 +63,6 @@
import { TraceDetailFlyout } from './flyout_components/trace_detail_flyout';
import { fetchAppById, initializeTabData } from '../helpers/utils';
import { QueryManager } from '../../../../common/query_manager/ppl_query_manager';
import { observabilityApplicationsID } from '../../../../common/constants/shared';

const searchBarConfigs = {
[TAB_EVENT_ID]: {
Expand Down Expand Up @@ -111,7 +107,7 @@
updateApp,
setAppConfigs,
setToasts,
toasts,

Check failure on line 110 in public/components/application_analytics/components/application.tsx

View workflow job for this annotation

GitHub Actions / Lint 

'toasts' is assigned a value but never used. Allowed unused vars must match /^_/u
setFilters,
callback,
queryManager,
Expand All @@ -136,7 +132,7 @@
const [serviceFlyoutName, setServiceFlyoutName] = useState<string>('');
const [traceFlyoutId, setTraceFlyoutId] = useState<string>('');
const [spanFlyoutId, setSpanFlyoutId] = useState<string>('');
const [spanDSL, setSpanDSL] = useState<any>({});

Check warning on line 135 in public/components/application_analytics/components/application.tsx

View workflow job for this annotation

GitHub Actions / Lint 

Unexpected any. Specify a different type
const [totalSpans, setTotalSpans] = useState<number>(0);
const [editVizId, setEditVizId] = useState<string>('');
const [visWithAvailability, setVisWithAvailability] = useState<EuiSelectOption[]>([]);
Expand All @@ -159,7 +155,7 @@
sessionStorage.setItem(`${application.name}EndTime`, newEndTime);
};

const addSpanFilter = (field: string, value: any) => {

Check warning on line 158 in public/components/application_analytics/components/application.tsx

View workflow job for this annotation

GitHub Actions / Lint 

Unexpected any. Specify a different type
const newFilters = [...filters];
const index = newFilters.findIndex(({ field: filterField }) => field === filterField);
if (index === -1) {
Expand Down Expand Up @@ -285,7 +281,7 @@
},
];

const nameColumnAction = (item: any) => openServiceFlyout(item);

Check warning on line 284 in public/components/application_analytics/components/application.tsx

View workflow job for this annotation

GitHub Actions / Lint 

Unexpected any. Specify a different type
const traceColumnAction = () => switchToTrace();

const getService = () => {
Expand All @@ -312,7 +308,7 @@
setSelectedTab(TAB_TRACE_ID);
};

const traceIdColumnAction = (item: any) => openTraceFlyout(item);

Check warning on line 311 in public/components/application_analytics/components/application.tsx

View workflow job for this annotation

GitHub Actions / Lint 

Unexpected any. Specify a different type

const getTrace = () => {
return (
Expand Down Expand Up @@ -348,7 +344,7 @@

const getLog = () => {
return (
<Explorer
<LegacyExplorer
key={`explorer_application-analytics-tab`}
pplService={pplService}
dslService={dslService}
Expand Down
Loading
Loading