Enhancement/search bar flint #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric <[email protected]>
Signed-off-by: Eric <[email protected]>
Signed-off-by: Eric <[email protected]>
joshuali925
commented
Feb 23, 2024
| import { QueryManager } from '../../../../../common/query_manager'; | ||
|
|
||
| export type OpenSearchDashboardsServices = Partial<CoreStart>; | ||
| export type DashboardsObservabilityServices = OpenSearchDashboardsServices & { |
There was a problem hiding this comment.
DashboardsObservabilityServices should contain CoreStart. would any services in core start be optional since it is defined as Partial<CoreStart>?
Comment on lines
+20
to
+22
| export interface ObservabilityDashboardsReactContextValue< | ||
| Services extends OpenSearchDashboardsServices | ||
| > { |
There was a problem hiding this comment.
why a separate generic Service instead of using DashboardsObservabilityServices defined above?
| const oldValue = useDashboardsObservability(); | ||
| const { value: mergedValue } = useMemo( | ||
| () => | ||
| createDashboardsObservabilityContext({ |
There was a problem hiding this comment.
Services is a generic type that extends OpenSearchDashboardsServices, how does it ensure that Observability specific services like pplService are passed in?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.