Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arora2013 solver #8

Merged
merged 3 commits into from
May 7, 2021
Merged

Add arora2013 solver #8

merged 3 commits into from
May 7, 2021

Conversation

jorgepiloto
Copy link
Owner

Solves for #3 by adding arora2013 solver.

@jorgepiloto
Copy link
Owner Author

The original report contains a critical error in the equations defining the way final velocity vectors are built from f and g functions. In addition, some signs concerning the W variable and its derivatives seem to be wrong.

At the moment, only the zero-revolution is implemented with all the test cases passing. Previous singularities were all commented within the source-code.

@jorgepiloto
Copy link
Owner Author

The complexity of the algorithm for the multi-revolution case is high. Because the timeline for the first release approaches and the zero-revolution case is heavily tested, let us implement this partially, discarding for the moment the multi-revolution scenario.

@jorgepiloto
Copy link
Owner Author

Before merging this, I would like to point it out the necessity of increasing the coverage of this algorithm. Even if the test-suite included at the moment might be seen robust, the fact that Arora's routine implements so many conditionals to check for solution region decreases the overall one. Anyway, package coverage remains over 90% at the moment, so merging this.

@jorgepiloto jorgepiloto merged commit 8d568ed into main May 7, 2021
@jorgepiloto jorgepiloto deleted the solver/arora2013 branch May 7, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant